Bump chart dependencies and set defaults for KUBECTL_CMD for multiarch execution. Fixes #94 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove default value of KUBECTL_CMD because it is architecture-dependant (amd64).
|
|
|
Hello! Could you review and fix the unit/integration tests errors? The upgrade of those dependencies is breaking the testing suite. |
|
I think the unit/integration test errors are already in your codebase and not because of the upgrade of the dependencies (at least some of them). I have run the tests with a single change in the README.md here https://github.com/cgiraldo/charts-passbolt/actions/runs/12387964061 and they are failing. |
|
Hi @cgiraldo! Long time no see! Thanks for the contribution and the report. Indeed the tests were failing as helm charts unittest got a new release that surfaced some flaky tests in our chart. We have updated the tests in main so you can rebase your PR. |
dlen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove default value of KUBECTL_CMD because it is architecture-dependant (amd64).