fixes challenge

passwordless-id · Aug 8, 2024 · 0ef2c07 · 0ef2c07
1 parent 1042afb
commit 0ef2c07
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 18 deletions.
diff --git a/README.md b/README.md
@@ -72,7 +72,7 @@ What follows is just an example of the most straightforward use case.
 ```
 import {client} from '@passwordless-id/webauthn'
 await client.register({
-  challenge: 'a random string generated by the server',
+  challenge: 'a random base64url encoded buffer from the server',
   user: 'John Doe'
 })
 ```
@@ -85,7 +85,7 @@ By default, this registers a passkey on any authenticator (local or roaming) wit
 ```
 import {client} from '@passwordless-id/webauthn'
 await client.authenticate({
-  challenge: 'a random string generated by the server'
+  challenge: 'a random base64url encoded buffer from the server'
 })
 ```
 

diff --git a/docs/demos/js/playground.js b/docs/demos/js/playground.js
@@ -53,20 +53,20 @@ const app = new Vue({
         },
         verification: {
             publicKey: "MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEWyyMt1l16_1rzDP63Ayw9EFpn1VbSt4NSJ7BOsDzqed5Z3aTfQSvzPBPHb4uYQuuckOKRbdoH9S0fEnSvNxpRg==", // null, 
-                     //"MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAzXUir6UgELFeM9il6id2vgZ1sWbZTk4C5JLIiMpg7lywwTRdp0i+lPP9rEdzcmwKwRLh5QT8DlPFQuKrUc8eXb9r+RPq/CvVOxVCqdK6A9fg0PDnvA3k7c5Ax5V5n/HcSw/uXVAzwstxQsbV5pOk0JDtys7rKiPjdO+XH5TbANNJE7PsS5j90zHLKNQaSybgF8V0v4Oz4I9u7IjVQKEz2V56E4Qfj/D7g0PCu63M5mNz5bGsmUzg5XwSRIaG3J3kDTuyTTGjPYhTnYFyWYXuMu1ZQ7JCe5FUv9m4oj3jH33VQEW3sorea7UOBjnSsLWp8MyE08M4tlY2xgyFL59obQIDAQAB",
+            //"MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAzXUir6UgELFeM9il6id2vgZ1sWbZTk4C5JLIiMpg7lywwTRdp0i+lPP9rEdzcmwKwRLh5QT8DlPFQuKrUc8eXb9r+RPq/CvVOxVCqdK6A9fg0PDnvA3k7c5Ax5V5n/HcSw/uXVAzwstxQsbV5pOk0JDtys7rKiPjdO+XH5TbANNJE7PsS5j90zHLKNQaSybgF8V0v4Oz4I9u7IjVQKEz2V56E4Qfj/D7g0PCu63M5mNz5bGsmUzg5XwSRIaG3J3kDTuyTTGjPYhTnYFyWYXuMu1ZQ7JCe5FUv9m4oj3jH33VQEW3sorea7UOBjnSsLWp8MyE08M4tlY2xgyFL59obQIDAQAB",
             algorithm: "ES256",
             authenticatorData: "SZYN5YgOjGh0NBcPZHZgW4_krrmihjLHmVzzuoMdl2MFAAAAAQ==", // null, 
-                             //"SZYN5YgOjGh0NBcPZHZgW4/krrmihjLHmVzzuoMdl2MFAAAAAQ==",
+            //"SZYN5YgOjGh0NBcPZHZgW4/krrmihjLHmVzzuoMdl2MFAAAAAQ==",
             clientData: "eyJ0eXBlIjoid2ViYXV0aG4uZ2V0IiwiY2hhbGxlbmdlIjoiMjRkMjI0ZDMtMWQwZi00MzAxLTg3NTktMzk4ODcwNTg1ZTU1Iiwib3JpZ2luIjoiaHR0cDovL2xvY2FsaG9zdDo4MDgwIiwiY3Jvc3NPcmlnaW4iOmZhbHNlfQ==", // null, 
-                      //"eyJ0eXBlIjoid2ViYXV0aG4uZ2V0IiwiY2hhbGxlbmdlIjoiWmpreE5URTBZVGN0TkRKa015MDBOMlU0TFdFME1HTXRZVFEyTkdRNVlqTmpNVGN3Iiwib3JpZ2luIjoiaHR0cDovL2xvY2FsaG9zdDo2MzM0MiIsImNyb3NzT3JpZ2luIjpmYWxzZSwib3RoZXJfa2V5c19jYW5fYmVfYWRkZWRfaGVyZSI6ImRvIG5vdCBjb21wYXJlIGNsaWVudERhdGFKU09OIGFnYWluc3QgYSB0ZW1wbGF0ZS4gU2VlIGh0dHBzOi8vZ29vLmdsL3lhYlBleCJ9",
+            //"eyJ0eXBlIjoid2ViYXV0aG4uZ2V0IiwiY2hhbGxlbmdlIjoiWmpreE5URTBZVGN0TkRKa015MDBOMlU0TFdFME1HTXRZVFEyTkdRNVlqTmpNVGN3Iiwib3JpZ2luIjoiaHR0cDovL2xvY2FsaG9zdDo2MzM0MiIsImNyb3NzT3JpZ2luIjpmYWxzZSwib3RoZXJfa2V5c19jYW5fYmVfYWRkZWRfaGVyZSI6ImRvIG5vdCBjb21wYXJlIGNsaWVudERhdGFKU09OIGFnYWluc3QgYSB0ZW1wbGF0ZS4gU2VlIGh0dHBzOi8vZ29vLmdsL3lhYlBleCJ9",
             signature: "MEYCIQDgSy1brw1UVCT4kzaZIiiihNuC7KvV2vm3gO5f1CSscQIhAM6-MihKO2jnF_BHeEJMYZ7jN-kz9TuWqYwJJzm4fOcl", //null, 
-                     //"E/XchoqDlSOanozr0o03DN++EEz5qVymtgiaLbepoysxgdxAz/uH/34wt7/YrUs7ESaH/3ni3/0mk71WRc9SP9GMRNYqKSeZkwAM+ZHMc7e3OEpOETWIBCO+aOKmKPflB/nVzXocNUHnhW/aw5UAOhU43qjjy1X9+5+t+60C6RyGaDXTz6Mk6rmgX3z21M8pOFw8VAAtUojX6ab+Lh48SaMN1Z2BK8Exh//pFjveMVngx4yuYRm6Tu7irRvGZVe7Wnii6GNUz56kT2Q4Fc8hR28c3+qufKWuaHLJUnsw6GILQNxemDzirlKBhXFjz7Ht7tyGaqUwFZr9q+93j/95Ag==",
+            //"E/XchoqDlSOanozr0o03DN++EEz5qVymtgiaLbepoysxgdxAz/uH/34wt7/YrUs7ESaH/3ni3/0mk71WRc9SP9GMRNYqKSeZkwAM+ZHMc7e3OEpOETWIBCO+aOKmKPflB/nVzXocNUHnhW/aw5UAOhU43qjjy1X9+5+t+60C6RyGaDXTz6Mk6rmgX3z21M8pOFw8VAAtUojX6ab+Lh48SaMN1Z2BK8Exh//pFjveMVngx4yuYRm6Tu7irRvGZVe7Wnii6GNUz56kT2Q4Fc8hR28c3+qufKWuaHLJUnsw6GILQNxemDzirlKBhXFjz7Ht7tyGaqUwFZr9q+93j/95Ag==",
             isValid: null
         }
     },
     methods: {
         newChallenge() {
-            return webauthn.utils.randomChallenge()
+            return webauthn.server.randomChallenge()
         },
         async register() {
             try {
@@ -85,7 +85,7 @@ const app = new Vue({
                 console.log(result)
                 this.registration.result = result
             }
-            catch(e) {
+            catch (e) {
                 console.warn(e)
                 this.$buefy.toast.open({
                     message: e,
@@ -107,7 +107,7 @@ const app = new Vue({
                 this.authentication.json = json
 
                 const credential = this.registration?.result?.credential
-                if(credential) {
+                if (credential) {
                     const result = await webauthn.server.verifyAuthentication(json, credential, {
                         challenge: this.authentication.options.challenge,
                         origin: this.origin,
@@ -118,7 +118,7 @@ const app = new Vue({
                     this.authentication.result = result
                 }
             }
-            catch(e) {
+            catch (e) {
                 console.warn(e)
                 this.$buefy.toast.open({
                     message: e,
@@ -130,7 +130,7 @@ const app = new Vue({
             try {
                 this.verification.isValid = await webauthn.server.verifySignature(this.verification)
             }
-            catch(e) {
+            catch (e) {
                 console.warn(e)
                 this.$buefy.toast.open({
                     message: e,
@@ -146,4 +146,4 @@ const app = new Vue({
             return webauthn.parsers.parseClient(clientData)
         }
     }
- })
+})
diff --git a/docs/demos/js/webauthn.min.js b/docs/demos/js/webauthn.min.js
diff --git a/docs/demos/js/webauthn.min.js.map b/docs/demos/js/webauthn.min.js.map
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@passwordless-id/webauthn",
-  "version": "2.0.3",
+  "version": "2.0.4",
   "description": "A small wrapper around the webauthn protocol to make one's life easier.",
 
   "type": "module",

diff --git a/src/server.ts b/src/server.ts
@@ -4,7 +4,7 @@ import { AuthenticationJSON, NamedAlgo, RegistrationJSON, RegistrationInfo, Auth
 import * as utils from './utils'
 
 
-export async function randomChallenge() {
+export function randomChallenge() {
     const buffer = crypto.getRandomValues(new Uint8Array(16)); // 128 bits
     return utils.toBase64url(buffer);
 }