-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ResidentKeyRequirement #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good.
Edit: @dIeGoLi An extra thumbs up for including the reference to the W3C specification.
@aseigler Would be nice to have a v3 beta release with that. Do you think that's possible? |
I could probably get this into a 3.1 beta |
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
- Coverage 77.41% 77.38% -0.03%
==========================================
Files 87 87
Lines 2404 2406 +2
Branches 402 402
==========================================
+ Hits 1861 1862 +1
- Misses 443 444 +1
Partials 100 100
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…catorSelection, mark RequireResidentKey as obsolete and update demo accordingly
Works for me, sorry it took so long to sort. |
#310
I can not think of a good unit test. I think it does not need one, right?