Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor package.json issues #1

Open
addyosmani opened this issue Dec 5, 2018 · 4 comments
Open

Minor package.json issues #1

addyosmani opened this issue Dec 5, 2018 · 4 comments

Comments

@addyosmani
Copy link

package.json refers to lib/index.js and /lib which don't appear to exist. Perhaps this needs to be updated to refer to index.js in root, @pastelsky?.. :)

image

https://github.com/pastelsky/network-idle-callback/blob/master/package.json#L7

These also appear to be path issues in the prepublish step.

I was trying network-idle-callback for a demo I'm working on and ran into issues with that part of the package today. Any chance of a fix/republish to npm? :)

@pastelsky
Copy link
Owner

pastelsky commented Dec 6, 2018

Hi @addyosmani ,
The lib/* files are transpiled and published only to npm. Installing it via yarn for eg. will give you this -
https://unpkg.com/[email protected]/lib/

I probably already had the lib folder created before publishing so didn't come across this error while building. Let me take a look. But you should be able to pull it off npm and use it just fine.

Also, there is a demo in the www folder that works locally, in case you were looking for one.

@addyosmani
Copy link
Author

Thank you for checking that out :) It was with a local build of the repo that I've seen the above issues.

Is the module vended as CommonJS intentionally? When referencing from unpkg or with an npm install for the browser we see module.exports issues. I can "fix" this by stripping CJS specific lines manually, but wanted to ask in case others ran into this.

@TonyBogdanov
Copy link
Contributor

@Qawsedrf0501

What?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@addyosmani @TonyBogdanov @pastelsky and others