-
Notifications
You must be signed in to change notification settings - Fork 4
fix: ensure log messages aren't lost when application exits #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dionhaefner
wants to merge
18
commits into
main
Choose a base branch
from
dion/better-teepipe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 76.42% 76.49% +0.06%
==========================================
Files 29 29
Lines 3359 3420 +61
Branches 526 534 +8
==========================================
+ Hits 2567 2616 +49
- Misses 558 569 +11
- Partials 234 235 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…t-core into dion/better-teepipe
andrinr
approved these changes
Nov 17, 2025
angela-ko
reviewed
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue or PR
#356, #357
Description of changes
This fixes the observed issue of missing logs (printed messages + tracebacks) in some scenarios, specifically when the interpreter crashes / exits before corresponding I/O pipes are exhausted.
Also renames
LogPipe->TeePipebecause that's really what it does (teeing).The primary difference is that
TeePipenow blocks the main thread when exiting while there are messages waiting in the pipe. Only when nothing has been read for X seconds do we continue with shutdown. This ensures that all queued up messages are forwarded properly.Testing done
new test + manual check that messages are now shown as expected on the reproducer from #356.