Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubscribeMetadata dont hold a list of methods for events #702

Draft
wants to merge 2 commits into
base: 3.10.x
Choose a base branch
from

Conversation

DanielBadura
Copy link
Member

@DanielBadura DanielBadura commented Feb 19, 2025

As mentioned in #701 this PR adjusts the API so that the metadata isnt holding a list of methods for an event anymore as this is not supported.

@DanielBadura DanielBadura changed the base branch from 3.11.x to dont-allow-subcribe-double-event February 19, 2025 13:56
@DanielBadura DanielBadura added this to the 4.0.0 milestone Feb 19, 2025
@DanielBadura DanielBadura self-assigned this Feb 19, 2025
@DanielBadura DanielBadura changed the title Subscribe metadata no method list subscribe SubscribeMetadata dont hold a list of methods for events Feb 19, 2025
Copy link

Hello 👋

here is the most recent benchmark result:

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 977.900μs (±0.00%) | 931.000μs (±0.00%) | +5.04%    | 34.382mb        | 34.913mb   | -1.52%      |
| benchLoad10000Events ()                | 56.543ms (±0.00%)  | 57.761ms (±0.00%)  | -2.11%    | 34.382mb        | 34.913mb   | -1.52%      |
| benchSave1Event ()                     | 980.000μs (±0.00%) | 1.034ms (±0.00%)   | -5.18%    | 34.382mb        | 34.382mb   | 0.00%       |
| benchSave10000Events ()                | 294.119ms (±0.00%) | 307.228ms (±0.00%) | -4.27%    | 34.382mb        | 34.382mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.668s (±0.00%)    | 9.176s (±0.00%)    | -5.53%    | 34.382mb        | 34.382mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.108s (±0.00%)    | 5.142s (±0.00%)    | -0.66%    | 34.382mb        | 34.382mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 979.400μs (±0.00%) | 996.300μs (±0.00%) | -1.70%    | 34.198mb        | 34.198mb   | 0.00%       |
| benchLoad10000Events ()                | 52.237ms (±0.00%)  | 50.891ms (±0.00%)  | +2.65%    | 34.198mb        | 34.198mb   | 0.00%       |
| benchSave1Event ()                     | 1.086ms (±0.00%)   | 969.800μs (±0.00%) | +11.94%   | 34.198mb        | 34.198mb   | 0.00%       |
| benchSave10000Events ()                | 217.321ms (±0.00%) | 226.733ms (±0.00%) | -4.15%    | 34.198mb        | 34.198mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.254s (±0.00%)    | 8.477s (±0.00%)    | -2.63%    | 34.199mb        | 34.199mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.905s (±0.00%)    | 4.950s (±0.00%)    | -0.91%    | 34.199mb        | 34.199mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 50.868ms (±0.00%)  | 50.937ms (±0.00%)  | -0.14%    | 34.273mb        | 34.273mb   | 0.00%       |
| benchLoad10000Events ()                | 908.800μs (±0.00%) | 925.800μs (±0.00%) | -1.84%    | 34.273mb        | 34.273mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.347ms (±0.00%)   | 4.363ms (±0.00%)   | -0.35%    | 37.575mb        | 37.575mb   | 0.00%       |
| benchSave10000Events () | 350.290ms (±0.00%) | 349.364ms (±0.00%) | +0.27%    | 37.577mb        | 37.578mb   | -0.00%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 77.090ms (±0.00%) | 75.502ms (±0.00%) | +2.10%    | 34.667mb        | 34.667mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.149s (±0.00%) | 3.136s (±0.00%) | +0.42%    | 46.815mb        | 46.815mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 882.300μs (±0.00%) | 906.800μs (±0.00%) | -2.70%    | 35.328mb        | 35.328mb   | 0.00%       |
| benchLoad10000Events ()                | 87.059ms (±0.00%)  | 87.811ms (±0.00%)  | -0.86%    | 35.328mb        | 35.328mb   | 0.00%       |
| benchSave1Event ()                     | 1.584ms (±0.00%)   | 1.467ms (±0.00%)   | +7.99%    | 35.328mb        | 35.328mb   | 0.00%       |
| benchSave10000Events ()                | 253.077ms (±0.00%) | 253.457ms (±0.00%) | -0.15%    | 35.331mb        | 35.331mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.869s (±0.00%)   | 12.430s (±0.00%)   | +3.53%    | 35.328mb        | 35.328mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.115s (±0.00%)    | 9.100s (±0.00%)    | +0.17%    | 35.829mb        | 35.829mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DanielBadura
Copy link
Member Author

Not sure why no BC-Break is here detected.

Base automatically changed from dont-allow-subcribe-double-event to 3.10.x February 21, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant