Add Basic Auth and Skip Health Check Option #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @patrickedqvist Can you give me some feedback on that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds 2 options for the Github Action:
basic_auth_credentials_base64skip_health_check@patrickedqvist I don't really understand the test setup and I am not sure if I am able to write tests with your vercel deployment. Also you are not using basic auth on your deployment, so not sure how to move forward here.
If you'd accept the skip health check feature but not the Basic Auth feature, I am happy to split the PR. Skip Health Check would also be sufficient for my use case.