Skip to content

Commit

Permalink
csi: drop go from bin (kubeflow#292)
Browse files Browse the repository at this point in the history
Signed-off-by: Isabella do Amaral <[email protected]>
  • Loading branch information
isinyaaa authored Aug 22, 2024
1 parent 837e254 commit 37be89d
Showing 1 changed file with 6 additions and 13 deletions.
19 changes: 6 additions & 13 deletions csi/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
MKFILE_PATH := $(abspath $(lastword $(MAKEFILE_LIST)))
PROJECT_PATH := $(patsubst %/,%,$(dir $(MKFILE_PATH)))
PROJECT_BIN := $(PROJECT_PATH)/bin
GO := $(PROJECT_BIN)/go1.21.9
GO ?= "$(shell which go)"

# add tools bin directory
PATH := $(PROJECT_BIN):$(PATH)
Expand Down Expand Up @@ -32,33 +32,26 @@ help: ## Display this help.

##@ Development

bin-go: ## Install go tool
GOBIN=$(PROJECT_BIN) go install golang.org/dl/go1.21.9@latest
$(PROJECT_BIN)/go1.21.9 download

.PHONY: bin
bin: bin-go ## Install required dependencies

.PHONY: tidy
tidy: ## Run go mod tidy.
${GO} mod tidy

.PHONY: fmt
fmt: bin ## Run go fmt against code.
fmt: ## Run go fmt against code.
${GO} fmt ./...

.PHONY: vet
vet: bin ## Run go vet against code.
vet: ## Run go vet against code.
${GO} vet ./...

.PHONY: test
test: fmt vet bin ## Run tests.
test: fmt vet ## Run tests.
${GO} test ./... -coverprofile cover.out

##@ Build

.PHONY: build
build: fmt vet bin ## Build binary.
build: fmt vet ## Build binary.
${GO} build -o bin/mr-storage-initializer main.go

.PHONY: run
Expand All @@ -75,4 +68,4 @@ docker-build-dev: ## Build container image using local model-registry module.

.PHONY: docker-push
docker-push: ## Push container image.
${DOCKER} push ${IMG}:$(IMG_VERSION)
${DOCKER} push ${IMG}:$(IMG_VERSION)

0 comments on commit 37be89d

Please sign in to comment.