Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR feedback - update token, adjust hard coded width #83

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

evwilkin
Copy link
Member

@evwilkin evwilkin commented Sep 3, 2024

Closes #79
Follow-up to #72

This PR updates the CSS in two ways:

  1. Replaces hard-coded border-radius property with corresponding token.
  2. Replaced hard-coded 92vw with a combination of tokens the correctly calculate the available space (minus the sidebar width, page main container margin, and page main section padding).

@evwilkin
Copy link
Member Author

evwilkin commented Sep 9, 2024

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. 👍🏻 ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tokens table style updates
2 participants