Added v6 RC updates and theme switcher #30
Conversation
|
@dlabaj is attempting to deploy a commit to the patternfly-extension-testing Team on Vercel. A member of the Team first needs to authorize it. |
dlabaj
changed the title
| import "@patternfly/react-core/dist/styles/base.css"; | ||
| import "@patternfly/patternfly/patternfly.css"; |
There was a problem hiding this comment.
This may be known but just in case
@patternfly/patternfly/patternfly.cssis all patternfly styles except for utility classes@patternfly/react-core/dist/styles/base.cssis just our global styles (no component/layout styles) minus font awesome and possibly other stuff that happens via patternfly-react/packages/react-core/scripts/copyStyles.mjs
So I'd want to make sure that with this update, styles aren't being pulled in twice/multiple times (once from patternfly.css and again from an individual component stylesheet - for example, button.css which will be imported when you import { Button } from "patternfly/react-core". You could see if that's the case by inspecting a button and seeing if you have the same button styles listed multiple times in dev tools with the duplicate styles crossed out.
And for reference:
- patternfly.css is about 1.5mb (you can use patternfly.min.css, it's 1.4mb)
- patternfly-base.css is about 184k
| @@ -59,7 +59,7 @@ export const ReleaseStatusTable: React.FunctionComponent = () => { | |||
| ]; | |||
|
|
|||
| return ( | |||
| <PageSection isWidthLimited> | |||
| <PageSection hasBodyWrapper isWidthLimited> | |||
There was a problem hiding this comment.
Just noting that hasBodyWrapper should be true by default - https://staging.patternfly.org/components/page#pagesection
| @@ -72,7 +91,7 @@ export const TestStatusTable: React.FunctionComponent<TestStatusTableProps> = ({ | |||
| const columns = ["Name", "Status", "Synced with upstream?"]; | |||
|
|
|||
| return ( | |||
| <PageSection isWidthLimited> | |||
| <PageSection hasBodyWrapper isWidthLimited> | |||
There was a problem hiding this comment.
another note that hasBodyWrapper should be true by default https://staging.patternfly.org/components/page#pagesection
| "@types/react": "18.0.28", | ||
| "@types/react-dom": "18.0.11", | ||
| "eslint": "8.35.0", | ||
| "@patternfly/patternfly": "6.0.0-prerelease.15", |
There was a problem hiding this comment.
since this is still open, this could be updated to the released v6 versions :)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Added v6 updates, theme switcher, and updated README.md.
Fixes issue #27