fix(pfFilter): fix plugin filters do not work if tables are set up serverSide #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgutride
requested changes
Jul 31, 2018
package.json
Outdated
| @@ -5,6 +5,7 @@ | |||
| "license": "Apache-2.0", | |||
| "dependencies": { | |||
| "bootstrap": "~3.3.7", | |||
| "datatables": "^1.10.18", | |||
There was a problem hiding this comment.
adding datatables as a required dependency is probably going to be a challenge for users, these should be absolute must-haves for users of PatternFly - can this be added as an optional dependency instead?
There was a problem hiding this comment.
Ah thanks for your response, sure i'll move it to optional dependency
Move datatables as optional dependencies
pebri86
commented
Aug 2, 2018
dgutride
approved these changes
Aug 21, 2018
|
The JS looks good - added @michael-coker to take a glance at the css if possible. |
|
I can't find the elements that the CSS modifications apply to in any of the table view test pages. What do I need to do to see the changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(pfFilter): fix plugin filters do not work if tables are set up serverSide
fix #1092
Description
fix pfFilter to use filtering on server side when datatable are set up using serverSide options.
Changes
Write a list of changes the PR introduces