-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alert): add pf-alert #2593
Draft
brianferry
wants to merge
15
commits into
main
Choose a base branch
from
feat/add-pf-alert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
33afe49
feat: init commit with pf-alert
brianferry df55c1d
feat: truncated title and timeout
brianferry 6185d07
feat(alert): adding plain, custom icons
brianferry 20eaf92
Merge branch 'main' of github.com:patternfly/patternfly-elements into…
brianferry 544a0c6
feat(alert): cleaning up css, fallback variables for important styles…
brianferry c68683a
feat(core): adding isEmpty, hasSlotted w/ default slot
brianferry da3c824
chore: adding changeset
brianferry 4a1dacf
Merge branch 'feat/core-default-slot' of github.com:patternfly/patter…
brianferry 9a03851
Update core/pfe-core/controllers/slot-controller.ts
brianferry 147b672
chore: merging with feat/default-slot
brianferry e1cfe19
fix(core): adding anonymous slot back to SlotController
brianferry 88e079d
Merge branch 'feat/core-default-slot' of github.com:patternfly/patter…
brianferry 8e2cd9e
feat(alert): multiple demos, jsdocs, adding pf-icon
brianferry d97a4f7
fix(alert): private css variables, moving ICONS call inline, removing…
brianferry 472fa59
docs(alert): inline scripts, heading tags fixing
brianferry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"@patternfly/pfe-core": minor | ||
--- | ||
|
||
`SlotController`: | ||
|
||
- Add `isEmpty` method to check if a slot is empty. If no slot name is provided it will check the default slot. (#2603) | ||
- `hasSlotted` method now returns default slot if no slot name is provided. (#2603) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# PatternFly Elements Alert | ||
|
||
`<pf-alert>` is a web component that provides a standard alert interface for displaying important messages to users. | ||
|
||
## Installation | ||
|
||
Load `<pf-alert>` via CDN: | ||
|
||
```html | ||
<script src="https://jspm.dev/@patternfly/elements/pf-alert/pf-alert"></script> | ||
``` | ||
|
||
Or, if you are using [NPM](https://npm.im), install it | ||
|
||
```bash | ||
npm install @patternfly/elements | ||
``` | ||
|
||
Then once installed, import it to your application: | ||
|
||
```js | ||
import '@patternfly/elements/pf-alert/pf-alert.js'; | ||
``` | ||
|
||
|
||
```html | ||
<pf-alert variant="info" header="Info alert title"></pf-alert> | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<link rel="stylesheet" href="demo.css"><script type="module" src="pf-alert.js"></script> | ||
|
||
<pf-alert header="Custom icon"> | ||
<pf-icon slot="icon" set="fas" icon="users" loading="idle"></pf-icon> | ||
</pf-alert> | ||
<pf-alert header="Custom info icon" variant="info"> | ||
<pf-icon slot="icon" set="fas" icon="box" loading="idle"></pf-icon> | ||
</pf-alert> | ||
<pf-alert header="Custom success icon" variant="success"> | ||
<pf-icon slot="icon" set="fas" icon="database" loading="idle"></pf-icon> | ||
</pf-alert> | ||
<pf-alert header="Custom warning icon" variant="warning"> | ||
<pf-icon slot="icon" set="fas" icon="server" loading="idle"></pf-icon> | ||
</pf-alert> | ||
<pf-alert header="Custom danger icon" variant="danger"> | ||
<pf-icon slot="icon" set="fas" icon="laptop" loading="idle"></pf-icon> | ||
</pf-alert> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
pf-alert { | ||
padding: 0.5rem; | ||
display: block; | ||
} | ||
|
||
pf-button { | ||
display: block; | ||
padding-block: 1em; | ||
} | ||
|
||
#timeout-alerts { | ||
min-height: 200px; | ||
border: 1px solid #000; | ||
margin: 0.5rem; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
<link rel="stylesheet" href="demo.css"><script type="module" src="pf-alert.js"></script> | ||
|
||
<h2> | ||
Inline | ||
</h2> | ||
|
||
<pf-alert header="Default inline" inline></pf-alert> | ||
<pf-alert variant="info" header="Info inline" inline></pf-alert> | ||
<pf-alert variant="success" header="Success inline" inline></pf-alert> | ||
<pf-alert variant="warning" header="Warning inline" inline></pf-alert> | ||
<pf-alert variant="danger" header="Danger inline" inline></pf-alert> | ||
|
||
<h2> | ||
Inline Plain | ||
</h2> | ||
|
||
<pf-alert header="Default inline" inline plain></pf-alert> | ||
<pf-alert variant="info" header="Info inline" inline plain></pf-alert> | ||
<pf-alert variant="success" header="Success inline" inline plain></pf-alert> | ||
<pf-alert variant="warning" header="Warning inline" inline plain></pf-alert> | ||
<pf-alert variant="danger" header="Danger inline" inline plain></pf-alert> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -0,0 +1,123 @@ | ||||
<link rel="stylesheet" href="demo.css"><script type="module" src="pf-alert.js"></script> | ||||
|
||||
<pf-alert header="Default alert title"></pf-alert> | ||||
<pf-alert variant="info" header="Info alert title"></pf-alert> | ||||
<pf-alert variant="success" header="Success alert title"></pf-alert> | ||||
<pf-alert variant="warning" header="Warning alert title"></pf-alert> | ||||
<pf-alert variant="danger" header="Danger alert title"></pf-alert> | ||||
|
||||
<h2> | ||||
Alert Variations | ||||
</h2> | ||||
|
||||
<pf-alert header="Success alert title" variant="success" dismissable> | ||||
<p>Success alert description. This should tell the user more information about the alert.</p> | ||||
<button slot="actions">View details</button> | ||||
<button slot="actions">Ignore</button> | ||||
</pf-alert> | ||||
|
||||
<pf-alert header="Success alert title" variant="success" dismissable> | ||||
<p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p> | ||||
<p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p> | ||||
</pf-alert> | ||||
|
||||
<pf-alert header="Success alert title" variant="success" dismissable> | ||||
<button slot="actions">View details</button> | ||||
<button slot="actions">Ignore</button> | ||||
</pf-alert> | ||||
|
||||
<pf-alert header="Success alert title" variant="success" dismissable> | ||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
<p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p> | ||||
<p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p> | ||||
<button slot="actions">View details</button> | ||||
<button slot="actions">Ignore</button> | ||||
<button slot="actions">Ignore</button> | ||||
<button slot="actions">Ignore</button> | ||||
<button slot="actions">Ignore</button> | ||||
<button slot="actions">Ignore</button> | ||||
</pf-alert> | ||||
|
||||
<pf-alert header="Success alert title" variant="success" dismissable></pf-alert> | ||||
|
||||
<h2> | ||||
Default Icons | ||||
</h2> | ||||
|
||||
<pf-alert header="Custom icon"> | ||||
<pf-icon slot="icon" set="fas" icon="users" loading="idle"></pf-icon> | ||||
</pf-alert> | ||||
<pf-alert header="Custom info icon" variant="info"> | ||||
<pf-icon slot="icon" set="fas" icon="box" loading="idle"></pf-icon> | ||||
</pf-alert> | ||||
<pf-alert header="Custom success icon" variant="success"> | ||||
<pf-icon slot="icon" set="fas" icon="database" loading="idle"></pf-icon> | ||||
</pf-alert> | ||||
<pf-alert header="Custom warning icon" variant="warning"> | ||||
<pf-icon slot="icon" set="fas" icon="server" loading="idle"></pf-icon> | ||||
</pf-alert> | ||||
<pf-alert header="Custom danger icon" variant="danger"> | ||||
<pf-icon slot="icon" set="fas" icon="laptop" loading="idle"></pf-icon> | ||||
</pf-alert> | ||||
|
||||
<h2> | ||||
Plain | ||||
</h2> | ||||
|
||||
<pf-alert header="Default plain" plain></pf-alert> | ||||
<pf-alert variant="info" header="Info plain" plain></pf-alert> | ||||
<pf-alert variant="success" header="Success plain" plain dismissable> | ||||
<p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p> | ||||
<button slot="actions">Ignore</button> | ||||
</pf-alert> | ||||
<pf-alert variant="warning" header="Warning plain" plain></pf-alert> | ||||
<pf-alert variant="danger" header="Danger plain" plain></pf-alert> | ||||
|
||||
<h2> | ||||
Inline | ||||
</h2> | ||||
|
||||
<pf-alert header="Default inline" inline></pf-alert> | ||||
<pf-alert variant="info" header="Info inline" inline></pf-alert> | ||||
<pf-alert variant="success" header="Success inline" inline></pf-alert> | ||||
<pf-alert variant="warning" header="Warning inline" inline></pf-alert> | ||||
<pf-alert variant="danger" header="Danger inline" inline></pf-alert> | ||||
|
||||
<h2> | ||||
Plain | ||||
</h2> | ||||
|
||||
<pf-alert header="Default inline" plain></pf-alert> | ||||
<pf-alert variant="info" header="Info inline" plain></pf-alert> | ||||
<pf-alert variant="success" header="Success inline" plain></pf-alert> | ||||
<pf-alert variant="warning" header="Warning inline" plain></pf-alert> | ||||
<pf-alert variant="danger" header="Danger inline" plain></pf-alert> | ||||
|
||||
<h2> | ||||
Inline Plain | ||||
</h2> | ||||
|
||||
<pf-alert header="Default inline" inline plain></pf-alert> | ||||
<pf-alert variant="info" header="Info inline" inline plain></pf-alert> | ||||
<pf-alert variant="success" header="Success inline" inline plain></pf-alert> | ||||
<pf-alert variant="warning" header="Warning inline" inline plain></pf-alert> | ||||
<pf-alert variant="danger" header="Danger inline" inline plain></pf-alert> | ||||
|
||||
<h2> | ||||
Truncated Title | ||||
</h2> | ||||
|
||||
<pf-alert style="width:100px;" truncate-title header="It was the best of times, it was the worst of times, it was the age of wisdom, it was the age of foolishness, it was the epoch of belief, it was the epoch of incredulity, it was the season of light, it was the season of darkness, it was the spring of hope, it was the winter of despair."></pf-alert> | ||||
|
||||
<h2> | ||||
Timeout | ||||
</h2> | ||||
|
||||
<pf-button id="create-timeout-alert">Create default timeout alert</pf-button> | ||||
<pf-button id="create-timeout-inline-alert">Create inline timeout alert</pf-button> | ||||
|
||||
<input type="range" id="timeout-range" min="0" max="10000" step="100" value="1000" /> | ||||
<label for="timeout-range">Timeout: <span id="timeout-value">1000</span>ms</label> | ||||
<pf-button id="create-Default-timeout-alert">Create Default timeout alert</pf-button> | ||||
|
||||
<section id="timeout-alerts"></section> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
<link rel="stylesheet" href="demo.css"><script type="module" src="pf-alert.js"></script> | ||
|
||
<pf-alert header="Default alert title"></pf-alert> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import '@patternfly/elements/pf-alert/pf-alert.js'; | ||
import '@patternfly/elements/pf-button/pf-button.js'; | ||
import '@patternfly/elements/pf-icon/pf-icon.js'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<link rel="stylesheet" href="demo.css"><script type="module" src="pf-alert.js"></script> | ||
|
||
<h2> | ||
Plain | ||
</h2> | ||
|
||
<pf-alert header="Default plain" plain></pf-alert> | ||
<pf-alert variant="info" header="Info plain" plain></pf-alert> | ||
<pf-alert variant="success" header="Success plain" plain dismissable> | ||
<p>Success alert description. This should tell the user more information about the alert. <a href="#">This is a link.</a></p> | ||
<button slot="actions">Ignore</button> | ||
</pf-alert> | ||
<pf-alert variant="warning" header="Warning plain" plain></pf-alert> | ||
<pf-alert variant="danger" header="Danger plain" plain></pf-alert> | ||
|
||
<h2> | ||
Inline Plain | ||
</h2> | ||
|
||
<pf-alert header="Default inline" inline plain></pf-alert> | ||
<pf-alert variant="info" header="Info inline" inline plain></pf-alert> | ||
<pf-alert variant="success" header="Success inline" inline plain></pf-alert> | ||
<pf-alert variant="warning" header="Warning inline" inline plain></pf-alert> | ||
<pf-alert variant="danger" header="Danger inline" inline plain></pf-alert> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<link rel="stylesheet" href="demo.css"><script type="module" src="timeout.js"></script> | ||
|
||
<h2> | ||
Timeout | ||
</h2> | ||
|
||
<pf-button id="create-timeout-alert">Create default timeout alert</pf-button> | ||
<pf-button id="create-timeout-inline-alert">Create inline timeout alert</pf-button> | ||
<pf-button id="create-custom-timeout-alert">Create custom timeout alert</pf-button> | ||
|
||
<input type="range" id="timeout-range" min="0" max="10000" step="100" value="1000" /> | ||
<label for="timeout-range">Timeout: <span id="timeout-value">1000</span>ms</label> | ||
<pf-button id="create-Default-timeout-alert">Create Default timeout alert</pf-button> | ||
|
||
<section id="timeout-alerts"></section> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of clarity, What I mean by inline is to replace
<link href
with <style and <script src with <scriptIn other words, each demo file would be self contained except for the files we ship in our package