Allow sending action which is rendered next to tile title (#283)

* Allow sending action which is rendered next to tile title * Change action to predefined button and add an example * Fix failing A11 tests * Use meta ID if present for card IDs * fix(ascii): Remove ascii doc examples. * fix(lint): Fixed linting issue. --------- Co-authored-by: Donald Labaj <[email protected]>
patternfly · Feb 28, 2024 · 0babc9c · 0babc9c
1 parent f1c5252
commit 0babc9c
Show file tree

Hide file tree

Showing 40 changed files with 96 additions and 2,484 deletions.
diff --git a/packages/dev/quickstart-adoc.js b/packages/dev/quickstart-adoc.js
diff --git a/packages/dev/src/AppContext.tsx b/packages/dev/src/AppContext.tsx
@@ -2,13 +2,11 @@ import './App.css';
 import { Page } from '@patternfly/react-core';
 import {
   LoadingBox,
-  QuickStart,
   QuickStartContextProvider,
   QuickStartContextValues,
   QuickStartDrawer,
   useLocalStorage,
 } from '@patternfly/quickstarts';
-import { loadJSONQuickStarts } from './quickstarts-data/asciidoc/quickstartLoader';
 import { allQuickStarts as yamlQuickStarts } from './quickstarts-data/quick-start-test-data';
 import React from 'react';
 import i18n from './i18n/i18n';
@@ -31,22 +29,12 @@ const App: React.FC<AppProps> = ({ children, showCardFooters }) => {
     console.log(allQuickStartStates);
   }, [allQuickStartStates]);
 
-  const [allQuickStarts, setAllQuickStarts] = React.useState<QuickStart[]>([]);
-  React.useEffect(() => {
-    const load = async () => {
-      const masGuidesQuickstarts = await loadJSONQuickStarts('');
-      setAllQuickStarts(yamlQuickStarts.concat(masGuidesQuickstarts));
-    };
-    setTimeout(() => {
-      load();
-    }, 500);
-  }, []);
 
   const language = localStorage.getItem('bridge/language') || 'en';
   const resourceBundle = i18n.getResourceBundle(language, 'quickstart');
 
   const valuesForQuickstartContext: QuickStartContextValues = {
-    allQuickStarts,
+    allQuickStarts: yamlQuickStarts,
     activeQuickStartID,
     setActiveQuickStartID,
     allQuickStartStates,
@@ -65,7 +53,7 @@ const App: React.FC<AppProps> = ({ children, showCardFooters }) => {
 
   return (
     <React.Suspense fallback={<LoadingBox />}>
-      {allQuickStarts && allQuickStarts.length ? (
+      {yamlQuickStarts && yamlQuickStarts.length ? (
         <QuickStartContextProvider value={valuesForQuickstartContext}>
           <QuickStartDrawer>
             <Page header={AppHeader} sidebar={AppSidebar} isManagedSidebar>

diff --git a/packages/dev/src/AppProps.tsx b/packages/dev/src/AppProps.tsx
@@ -2,15 +2,13 @@ import './App.css';
 import { Page, Button } from '@patternfly/react-core';
 import {
   LoadingBox,
-  QuickStart,
   QuickStartContainer,
   QuickStartContainerProps,
   useLocalStorage,
   setQueryArgument,
   removeQueryArgument,
   QUICKSTART_ID_FILTER_KEY,
 } from '@patternfly/quickstarts';
-import { loadJSONQuickStarts } from './quickstarts-data/asciidoc/quickstartLoader';
 import { allQuickStarts as yamlQuickStarts } from './quickstarts-data/quick-start-test-data';
 import React from 'react';
 import i18n from './i18n/i18n';
@@ -35,31 +33,19 @@ const App: React.FC<AppProps> = ({ children, showCardFooters }) => {
     console.log(allQuickStartStates);
   }, [allQuickStartStates]);
 
-  const [loading, setLoading] = React.useState(true);
-  const [quickStarts, setQuickStarts] = React.useState<QuickStart[]>([]);
-  React.useEffect(() => {
-    const load = async () => {
-      const masGuidesQuickstarts = await loadJSONQuickStarts('');
-      setQuickStarts(yamlQuickStarts.concat(masGuidesQuickstarts));
-      setLoading(false);
-    };
-    setTimeout(() => {
-      load();
-    }, 500);
-  }, []);
+
 
   const withQueryParams = true;
 
   const drawerProps: QuickStartContainerProps = {
-    quickStarts,
+    quickStarts: yamlQuickStarts,
     activeQuickStartID,
     allQuickStartStates,
     setActiveQuickStartID,
     setAllQuickStartStates,
     resourceBundle,
     showCardFooters,
     language,
-    loading,
     useQueryParams: withQueryParams,
     alwaysShowTaskReview: true,
     markdown: {