Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove showdown as dependency, update peerDep version of showdown #266

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Remove showdown as dependency, update peerDep version of showdown #266

merged 1 commit into from
Oct 30, 2023

Conversation

jschuler
Copy link
Collaborator

@jschuler jschuler commented Oct 27, 2023 •
edited
Loading

Closes #262

@netlify
Copy link

netlify bot commented Oct 27, 2023 •
edited
Loading

✅ Deploy Preview for quickstarts ready!

Name Link
🔨 Latest commit baed099
🔍 Latest deploy log https://app.netlify.com/sites/quickstarts/deploys/653c3fa71b45ba0008da29ea
😎 Deploy Preview https://deploy-preview-266--quickstarts.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jessiehuff
jessiehuff approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@jessiehuff jessiehuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nicolethoen
nicolethoen reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're in here, should you bump the PF dependency versions to the latest?

wise-king-sullyman
wise-king-sullyman approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything so far looks good to me. Are we bumping the PF deps under this PR?

@jessiehuff
Copy link
Collaborator

It looks like this PR will address that: #267

@jschuler jschuler merged commit c681afb into main Oct 30, 2023
7 checks passed
@github-actions
Copy link

🎉 This PR is included in version 5.1.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jschuler jschuler mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolethoen nicolethoen nicolethoen left review comments

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@jessiehuff jessiehuff jessiehuff approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted released on @prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CVE-2020-7608
4 participants
@jschuler @jessiehuff @wise-king-sullyman @nicolethoen