refactor (PR review)

patternfly · Sep 25, 2024 · 92e0d86 · 92e0d86
1 parent 933e273
commit 92e0d86
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/.../src/rules/v6/emptyStateHeaderMoveIntoEmptyState/emptyStateHeader-move-into-emptyState.ts b/.../src/rules/v6/emptyStateHeaderMoveIntoEmptyState/emptyStateHeader-move-into-emptyState.ts
@@ -234,14 +234,16 @@ module.exports = {
             titleTextAttribute
           );
 
-          const titleText =
-            titleTextPropValue ||
-            (hasChildren
+          const createTitleTextPropFromChildren = () =>
+            hasChildren
               ? `titleText=${getChildrenAsAttributeValueText(
                   context,
                   header.children
                 )}`
-              : "");
+              : "";
+
+          const titleText =
+            titleTextPropValue || createTitleTextPropFromChildren();
 
           const iconPropValue = getExpression(headerIconAttribute?.value);