Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EmptyState): make titleText optional #770

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor no.2
adamviktora committed Sep 25, 2024
commit f8a4c1a3204754d71875eb9354fa6d3f57be6b52
Original file line number Diff line number Diff line change
@@ -234,16 +234,14 @@ module.exports = {
titleTextAttribute
);

const createTitleTextPropFromChildren = () =>
hasChildren
? `titleText=${getChildrenAsAttributeValueText(
context,
header.children
)}`
: "";

const titleText =
titleTextPropValue || createTitleTextPropFromChildren();
const childrenTitleText = hasChildren
? `titleText=${getChildrenAsAttributeValueText(
context,
header.children
)}`
: "";

const titleText = titleTextPropValue || childrenTitleText;

const iconPropValue = getExpression(headerIconAttribute?.value);