Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass styles not referenced in examples #72

Open
evwilkin opened this issue Dec 10, 2024 · 0 comments · May be fixed by #73
Open

Sass styles not referenced in examples #72

evwilkin opened this issue Dec 10, 2024 · 0 comments · May be fixed by #73
Labels

Comments

@evwilkin
Copy link
Member

This package contains a /sass directory with the component styles but these are compiled directly to the dist/css directory and not referenced by the examples.

Instead, the styles are mostly duplicated in separate CSS files alongside the examples themselves and there is no concrete connection between the styles shipped with the package vs. the styles referenced in the examples, which has caused inconsistencies between the two such as the vertical tabs spacing in the package code (left) vs. example styles (right):

Ideally this sass code should be converted into css that can be passed to the patternfly-docs build which should apply the styles to the example code by default, and then separately copied into the dist directory, somewhat similar to this change in react-user-feedback (except that sass file was just changed directly to css).

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Dec 10, 2024
@evwilkin evwilkin changed the title Sass styles not compiled for use in examples Sass styles not referenced in examples Dec 10, 2024
@evwilkin evwilkin linked a pull request Dec 16, 2024 that will close this issue
@dlabaj dlabaj moved this from Needs triage to Ready to assign in PatternFly Issues Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready to assign
Development

Successfully merging a pull request may close this issue.

1 participant