You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead, the styles are mostly duplicated in separate CSS files alongside the examples themselves and there is no concrete connection between the styles shipped with the package vs. the styles referenced in the examples, which has caused inconsistencies between the two such as the vertical tabs spacing in the package code (left) vs. example styles (right):
Ideally this sass code should be converted into css that can be passed to the patternfly-docs build which should apply the styles to the example code by default, and then separately copied into the dist directory, somewhat similar to this change in react-user-feedback (except that sass file was just changed directly to css).
The text was updated successfully, but these errors were encountered:
This package contains a
/sass
directory with the component styles but these are compiled directly to thedist/css
directory and not referenced by the examples.Instead, the styles are mostly duplicated in separate CSS files alongside the examples themselves and there is no concrete connection between the styles shipped with the package vs. the styles referenced in the examples, which has caused inconsistencies between the two such as the vertical tabs spacing in the package code (left) vs. example styles (right):
Ideally this sass code should be converted into css that can be passed to the patternfly-docs build which should apply the styles to the example code by default, and then separately copied into the dist directory, somewhat similar to this change in react-user-feedback (except that sass file was just changed directly to css).
The text was updated successfully, but these errors were encountered: