Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): compile & use scss in examples #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evwilkin
Copy link
Member

Closes #72

This PR removes the custom stylesheets for each example and instead compiles the SASS locally to CSS, passes that to docs framework to be used in the examples, and then copies the compiled CSS to the dist directory.

Note: this will require design review - the shipped styles have not changed but the examples now differ in substantial ways such as blue borders at the top of Catalog Tiles.

@patternfly-build
Copy link

patternfly-build commented Dec 16, 2024

@christianvogt
Copy link

The preview loses the hover treatment background. Is this intentional that the vertical tabs don't get this treatment?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sass styles not referenced in examples
3 participants