feat(v6): Update to PatternFly V6 Versions #54
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,46 @@ | ||
| .filter-panel-pf { | ||
|
There was a problem hiding this comment. Ideally this whole thing would be a |
||
| margin-block-start: 0; | ||
| margin-block-end: var(--pf-t--global--spacer--xl); | ||
| margin-inline: 0; | ||
| padding-inline: var(--pf-t--global--spacer--md); | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: var(--pf-t--global--spacer--lg); | ||
| } | ||
|
|
||
| .filter-panel-pf-category-title { | ||
| border: 0; | ||
| font-size: var(--pf-t--global--font--size--body--sm); | ||
| margin-block-start: 0; | ||
| margin-block-end: var(--pf-t--global--spacer--sm); | ||
| margin-inline: 0; | ||
| font-weight: var(--pf-t--global--font--weight--body--bold); | ||
| } | ||
|
|
||
| .filter-panel-pf-category-items { | ||
| margin-block: 0; | ||
| } | ||
|
|
||
| .filter-panel-pf-category-items .pf-v6-c-button.pf-m-link { | ||
| padding: 0; | ||
| } | ||
|
|
||
| .filter-panel-pf-category-items > * + * { | ||
| margin-block-start: var(--pf-t--global--spacer--sm); | ||
| } | ||
|
|
||
| .filter-panel-pf-category-item { | ||
| font-weight: var(--pf-t--global--font--weight--body); | ||
| } | ||
|
|
||
| .filter-panel-pf-category-item:first-of-type { | ||
| margin-block-start: 0; | ||
| } | ||
|
|
||
| .filter-panel-pf-category-item .item-icon { | ||
| padding-inline-end: var(--pf-t--global--spacer--xs); | ||
|
There was a problem hiding this comment. It seems like this spacer/padding and the one on |
||
| } | ||
|
|
||
| .filter-panel-pf-category-item .item-count { | ||
| padding-inline-start: var(--pf-t--global--spacer--xs); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,18 @@ | ||
| .properties-side-panel-pf { | ||
|
There was a problem hiding this comment. mentioned this above but all of the styles in this stylesheet come with the |
||
| width: 165px; | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: var(--pf-t--global--spacer--lg); | ||
| } | ||
|
|
||
| .properties-side-panel-pf-property-label { | ||
| font-weight: var(--pf-t--global--font--weight--body--bold) !important; | ||
| font-size: var(--pf-t--global--font--size--body--sm) !important; | ||
| margin: 0 !important; | ||
| } | ||
|
|
||
| .properties-side-panel-pf-property-value { | ||
| font-size: var(--pf-t--global--font--size--body--regular) !important; | ||
| margin-top: var(--pf-t--global--spacer--sm); | ||
| word-break: break-word; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the border and example padding so it's clear what's coming from
<FilterSidePanel>and what's part of the example. Left the width because there is no width on<FilterSidePanel>and I'm assuming this panel goes into some parent/container with a constrained width, so this will mimic closer how the component will display. Ideally I'd probably drop this width, too, so you're just seeing the extension styles.Just dropping a note here but this and the properties side panel seem to share some styling - they're narrow, probably have padding around them. And
<FilterSidePanel>has padding and no width, and<PropertiesSidePanel>has a width and no padding. I'm guessing that's fine, but wondering if there could be some consistency there.