-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHCLOUD-34195 Updates to Ansible logo #312
Conversation
Bumps [@octokit/plugin-paginate-rest](https://github.com/octokit/plugin-paginate-rest.js) from 11.3.0 to 11.3.3. - [Release notes](https://github.com/octokit/plugin-paginate-rest.js/releases) - [Commits](octokit/plugin-paginate-rest.js@v11.3.0...v11.3.3) --- updated-dependencies: - dependency-name: "@octokit/plugin-paginate-rest" dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/bonjour](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/bonjour) from 3.5.10 to 3.5.13. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/bonjour) --- updated-dependencies: - dependency-name: "@types/bonjour" dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [binary-extensions](https://github.com/sindresorhus/binary-extensions) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/sindresorhus/binary-extensions/releases) - [Commits](sindresorhus/binary-extensions@v2.2.0...v2.3.0) --- updated-dependencies: - dependency-name: binary-extensions dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@octokit/request](https://github.com/octokit/request.js) from 9.1.1 to 9.1.3. - [Release notes](https://github.com/octokit/request.js/releases) - [Commits](octokit/request.js@v9.1.1...v9.1.3) --- updated-dependencies: - dependency-name: "@octokit/request" dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [pirates](https://github.com/danez/pirates) from 4.0.5 to 4.0.6. - [Release notes](https://github.com/danez/pirates/releases) - [Commits](danez/pirates@v4.0.5...v4.0.6) --- updated-dependencies: - dependency-name: pirates dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/aria-query](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/aria-query) from 5.0.1 to 5.0.4. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/aria-query) --- updated-dependencies: - dependency-name: "@types/aria-query" dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/http-proxy](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/http-proxy) from 1.17.11 to 1.17.15. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/http-proxy) --- updated-dependencies: - dependency-name: "@types/http-proxy" dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/json-schema](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/json-schema) from 7.0.12 to 7.0.15. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/json-schema) --- updated-dependencies: - dependency-name: "@types/json-schema" dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [caniuse-lite](https://github.com/browserslist/caniuse-lite) from 1.0.30001649 to 1.0.30001653. - [Commits](browserslist/caniuse-lite@1.0.30001649...1.0.30001653) --- updated-dependencies: - dependency-name: caniuse-lite dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…it/plugin-paginate-rest-11.3.3
…/bonjour-3.5.13
…y-extensions-2.3.0
…it/request-9.1.3
…/aria-query-5.0.4
…/http-proxy-1.17.15
…/json-schema-7.0.15
…se-lite-1.0.30001653
Just a few comments, overall it looks great! 🙂 |
Hey @fhlavac Do you suggest we keep or remove the unsupported state? If we keep it then it'll need to pf-t--global--icon--color--disabled applied to the icon Also it looks like the redhat AAP logo needs to be added in still |
I forgot to update the example file, it should be there now. |
I just suggested making the unsupported state available for both icons, now it is available only for the standalone Ansible, not Red Hat one. |
@kaylachumley do we have any update on how/if to change the RHAP disabled state colors? |
Dismissing since we need an answer on the RHAAP disabled state colors before merging.
@aferd from what @kaylachumley found out it looks like there will be no RHAAP unsupported state for now, so we should be good. |
@aferd I've resolved the conflicts, just we may need the snapshots to be updated |
closes #221
https://issues.redhat.com/browse/RHCLOUD-34195