Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery to the about page #366

Merged
merged 4 commits into from
Oct 14, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,27 @@ id: About component groups
sortValue: 1
sourceLink: https://github.com/patternfly/react-component-groups/blob/main/packages/module/patternfly-docs/content/extensions/component-groups/about-component-groups.md
---
import { SectionGallery } from '@patternfly/documentation-framework/components/sectionGallery/sectionGallery';
import galleryData from './gallery-data.json';

Component groups lives in its own package [`@patternfly/react-component-groups`](https://www.npmjs.com/package/@patternfly/react-component-groups)

# Component groups

The component groups extension contains a range of React components that are more complex than basic PatternFly components. These component groups combine and adjust multiple base components to provide opinionated solutions for recurring use cases across products using PatternFly.
The component groups extension contains a range of React components that are more complex than basic PatternFly components. These component groups combine and adjust multiple base components to provide opinionated solutions for recurring use cases across products using PatternFly.

The creation and maintenance of this extension is a collaborative effort between the PatternFly and Red Hat Hybrid Cloud Console teams. All component groups receive accessibility and design reviews, and we are working to improve internationalization, add unit test coverage, and ensure that CSS overrides all correctly reference the PatternFly CSS API.
The creation and maintenance of this extension is a collaborative effort between the PatternFly and Red Hat Hybrid Cloud Console teams. All component groups receive accessibility and design reviews, and we are working to improve internationalization, add test coverage, and ensure that CSS overrides all correctly reference the PatternFly CSS API.

Below, you can see a gallery of categories representing the components:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Below, you can see a gallery of categories representing the components:
There are a few different functional categories of component groups:


<SectionGallery
section="Component groups"
galleryItemsData={galleryData}
placeholderText="Search component groups by name"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
placeholderText="Search component groups by name"
placeholderText="Search component groups by name"

maybe we can just remove the search bar for now, since there's not a lot to filter through? but if that's a lot of work, it's doing no harm by being there!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edonehoo the gallery component does not allow it yet. We may want to talk to @nicolethoen about the possibility of adding that configuration.

includeSubsections={true}
hasGridText={true}
isFullWidth={false}
/>

**Note:** This extension replaces [`RedHatInsights/frontend-components`](https://github.com/RedHatInsights/frontend-components). If you previoulsy used `frontend-components`, you can refer to [this migration guide](https://github.com/patternfly/react-component-groups/blob/main/migration.md) to help you transition to `react-component-groups`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note:** This extension replaces [`RedHatInsights/frontend-components`](https://github.com/RedHatInsights/frontend-components). If you previoulsy used `frontend-components`, you can refer to [this migration guide](https://github.com/patternfly/react-component-groups/blob/main/migration.md) to help you transition to `react-component-groups`.
**Note:** This extension replaces [`RedHatInsights/frontend-components`](https://github.com/RedHatInsights/frontend-components). If you previoulsy used `frontend-components`, you can refer to [this migration guide](https://github.com/patternfly/react-component-groups/blob/main/migration.md) to help you transition to `react-component-groups`.

What do you think about moving this up to line 11 or so? Right below the note about the package location. Just to make sure it's easy to spot

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!


Expand All @@ -25,4 +38,4 @@ Specific contribution guidelines and instructions are outlined in [the component

We aim to align the standards of component groups as closely as possible with existing PatternFly standards. Given that this is a multi-team collaboration, we will continue to work towards this goal together.

If you notice a bug or have a suggestion for a new component group, feel free to file an issue in our [GitHub repository](https://github.com/patternfly/react-component-groups/issues)! Please make sure to check if there is already a pre-existing issue before creating a new issue.
If you notice a bug or have a suggestion for a new component group, open an issue in our [GitHub repository](https://github.com/patternfly/react-component-groups/issues)! Please make sure to check if there is already a pre-existing issue before creating a new one.
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
# Sidenav top-level section
# should be the same for all markdown files
section: extensions
subsection: Component groups
section: Component groups
subsection: Controls
# Sidenav secondary level section
# should be the same for all markdown files
id: Responsive actions
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"content-containers": {
"summary": "Provide layout components to organize and display content in structured and flexible formats."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"summary": "Provide layout components to organize and display content in structured and flexible formats."
"summary": "Organize and display information in structured or flexible containers."

},
"controls": {
"summary": "Include components that manage user interactions and input, enabling intuitive navigation and selection."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"summary": "Include components that manage user interactions and input, enabling intuitive navigation and selection."
"summary": "Enable more effective navigation and selection by providing users with options for interaction and input."

},
"error-communication": {
"summary": "Contain various error and alert states to communicate issues or restrictions."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"summary": "Contain various error and alert states to communicate issues or restrictions."
"summary": "Communicate issues or restrictions through error and alert states."

},
"helpers": {
"summary": "Offer utility components that enhance usability and provide additional guidance or information within the UI."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"summary": "Offer utility components that enhance usability and provide additional guidance or information within the UI."
"summary": "Provide users with utilities that enhance usability and provide additional guidance or information within the UI."

},
"status-and-state-indicators": {
"summary": "Visualize entity states, statuses, and loading indicators to inform users of system conditions or processes."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"summary": "Visualize entity states, statuses, and loading indicators to inform users of system conditions or processes."
"summary": "Inform users of system conditions or processes through visualizations of entity states, statuses, and loading indicators."

}
}
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1760,9 +1760,9 @@
version "5.0.0-prerelease.0"
resolved "file:packages/module"
dependencies:
"@patternfly/react-core" "^6.0.0-alpha.101"
"@patternfly/react-icons" "^6.0.0-alpha.36"
"@patternfly/react-table" "^6.0.0-alpha.102"
"@patternfly/react-core" "^6.0.0-prerelease.21"
"@patternfly/react-icons" "^6.0.0-prerelease.7"
"@patternfly/react-table" "^6.0.0-prerelease.22"
clsx "^2.1.1"
react-jss "^10.10.0"

Expand Down
Loading