Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DetailsPage cleanup #42

Merged
merged 6 commits into from
Nov 21, 2023
Merged

DetailsPage cleanup #42

merged 6 commits into from
Nov 21, 2023

Conversation

fhlavac
Copy link
Collaborator

@fhlavac fhlavac commented Sep 27, 2023

RHCLOUD-28564

  • did some cleanup and simplification of the DetailsPage's API

@fhlavac fhlavac force-pushed the details-page branch 2 times, most recently from 20588d6 to 9db9cc8 Compare November 21, 2023 16:56
@fhlavac fhlavac marked this pull request as ready for review November 21, 2023 16:56
@fhlavac fhlavac changed the title Details page cleanup DRAFT DetailsPage cleanup Nov 21, 2023
@fhlavac fhlavac force-pushed the details-page branch 2 times, most recently from 7042f33 to 744f480 Compare November 21, 2023 17:25
@fhlavac fhlavac requested review from edonehoo, dlabaj, karelhala and Hyperkid123 and removed request for edonehoo November 21, 2023 17:26
Copy link
Collaborator

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then the a11y error it looks good. I added the suggestion to fix it.

}}
role="nav"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
role="nav"
role="navigation"

@fhlavac fhlavac merged commit 7ad384d into patternfly:main Nov 21, 2023
4 checks passed
@fhlavac fhlavac deleted the details-page branch November 21, 2023 18:10
Copy link

🎉 This PR is included in version 5.0.0-prerelease.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants