Skip to content

Commit

Permalink
Upgraded to latest react core for v6 beta. (#63)
Browse files Browse the repository at this point in the history
* chore(pf-issues): Updated code to push issues to PatternFly Issues. (#52)

* Fix link to virt-manager.org/download (#51)

* chore: Create dependabot.yml

* chore(deps): update novnc to 1.5.0 (#57)

* fix(build): Update README.md to restart build that didn't deploy.

* fix(beta): Upgraded to beta release candidate and mereged main fixes.

fix(beta):

* fix(doc-framework): Upgraded to the latest document framework.

---------

Co-authored-by: Pierre CORSINI <[email protected]>
Co-authored-by: Nicole Thoen <[email protected]>
Co-authored-by: Jelle van der Waa <[email protected]>
  • Loading branch information
4 people authored Jul 30, 2024
1 parent 993717c commit aef5e4b
Show file tree
Hide file tree
Showing 17 changed files with 405 additions and 475 deletions.
37 changes: 37 additions & 0 deletions .github/workflows/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
version: 2
updates:
- package-ecosystem: npm
directory: "/"
schedule:
interval: weekly
day: tuesday
time: "12:00"
timezone: EST
allow:
- dependency-type: "all"
ignore:
- dependency-name: "*"
update-types:
- version-update:semver-major
open-pull-requests-limit: 10
reviewers:
- nicolethoen
- dlabaj

- package-ecosystem: npm
directory: "/packages/module"
schedule:
interval: weekly
day: tuesday
time: "12:00"
timezone: EST
allow:
- dependency-type: "all"
ignore:
- dependency-name: "*"
update-types:
- version-update:semver-major
open-pull-requests-limit: 10
reviewers:
- nicolethoen
- dlabaj
2 changes: 1 addition & 1 deletion .github/workflows/extensions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ jobs:
steps:
- uses: actions/[email protected]
with:
project-url: https://github.com/orgs/patternfly/projects/12
project-url: https://github.com/orgs/patternfly/projects/7
github-token: ${{ secrets.GH_PROJECTS }}
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ or
```
npm install @patternfly/react-console --save
```

### Usage

It's strongly advised to use the PatternFly Base CSS in your whole project, or some components may diverge in appearance:
Expand Down
14 changes: 7 additions & 7 deletions packages/module/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
"tag": "alpha"
},
"dependencies": {
"@novnc/novnc": "^1.3.0",
"@patternfly/react-core": "6.0.0-alpha.61",
"@patternfly/react-styles": "6.0.0-alpha.23",
"@novnc/novnc": "^1.5.0",
"@patternfly/react-core": "^6.0.0-alpha.94",
"@patternfly/react-styles": "^6.0.0-alpha.33",
"@spice-project/spice-html5": "^0.2.1",
"file-saver": "^1.3.8",
"react-jss": "^10.10.0",
Expand All @@ -49,11 +49,11 @@
"react-dom": "^17 || ^18"
},
"devDependencies": {
"@patternfly/documentation-framework": "6.0.0-alpha.41",
"@patternfly/patternfly": "6.0.0-alpha.139",
"@patternfly/documentation-framework": "6.0.0-alpha.69",
"@patternfly/patternfly": "6.0.0-alpha.205",
"@patternfly/patternfly-a11y": "^4.3.1",
"@patternfly/react-code-editor": "6.0.0-alpha.61",
"@patternfly/react-table": "6.0.0-alpha.61",
"@patternfly/react-code-editor": "6.0.0-alpha.94",
"@patternfly/react-table": "6.0.0-alpha.95",
"monaco-editor": "^0.34.1",
"rimraf": "^2.6.2",
"serve": "^14.2.3"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ pageData.examples = {

const Component = () => (
<React.Fragment>
<AutoLinkHeader {...{"id":"note","size":"h3","className":"ws-title ws-h3"}}>
<AutoLinkHeader {...{"id":"note","headingLevel":"h3","className":"ws-title ws-h3"}}>
{`Note`}
</AutoLinkHeader>
<p {...{"className":"pf-v6-c-content--p ws-p "}}>
Expand All @@ -380,7 +380,7 @@ const Component = () => (
</code>
</PatternflyThemeLink>
</p>
<AutoLinkHeader {...{"id":"examples","size":"h2","className":"ws-title ws-h2"}}>
<AutoLinkHeader {...{"id":"examples","headingLevel":"h2","className":"ws-title ws-h2"}}>
{`Examples`}
</AutoLinkHeader>
{React.createElement(pageData.examples["Basic Usage"])}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
import React from 'react';
import { Select, SelectOption, MenuToggle, MenuToggleElement, SelectList } from '@patternfly/react-core';
import {
MenuToggle,
MenuToggleElement,
Select,
SelectOption,
SelectList
} from '@patternfly/react-core';

import { constants } from '../common/constants';
import { createUseStyles } from 'react-jss';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ exports[`AccessConsoles with SerialConsole and VncConsole as children 1`] = `
aria-expanded="false"
aria-label="Console type toggle"
class="pf-v6-c-menu-toggle"
data-ouia-component-id="OUIA-Generated-MenuToggle-1"
data-ouia-component-type="PF6/MenuToggle"
data-ouia-safe="true"
id="pf-v6-c-console__type-selector"
style="width: 100%;"
type="button"
Expand Down Expand Up @@ -91,7 +94,11 @@ exports[`AccessConsoles with preselected SerialConsole 1`] = `
data-ouia-safe="true"
type="button"
>
Disconnect
<span
class="pf-v6-c-button__text"
>
Disconnect
</span>
</button>
<button
aria-disabled="false"
Expand All @@ -101,7 +108,11 @@ exports[`AccessConsoles with preselected SerialConsole 1`] = `
data-ouia-safe="true"
type="button"
>
Reset
<span
class="pf-v6-c-button__text"
>
Reset
</span>
</button>
</div>
<div
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const MoreInformationDefaultContent: React.FunctionComponent<MoreInformat
<MoreInformationInstallVariant os="Windows">
<div>
Download the MSI from{' '}
<a href="https://virt-manager.org/download/" target="_blank" rel="noopener noreferrer">
<a href="https://virt-manager.org/download" target="_blank" rel="noopener noreferrer">
virt-manager.org
</a>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ exports[`DesktopViewer default MoreInformationContent 1`] = `
<div>
Download the MSI from
<a
href="https://virt-manager.org/download/"
href="https://virt-manager.org/download"
rel="noopener noreferrer"
target="_blank"
>
Expand Down Expand Up @@ -160,7 +160,11 @@ exports[`DesktopViewer empty 1`] = `
disabled=""
type="button"
>
Launch Remote Viewer
<span
class="pf-v6-c-button__text"
>
Launch Remote Viewer
</span>
</button>
</div>
</div>
Expand Down Expand Up @@ -205,7 +209,11 @@ exports[`DesktopViewer with Spice and VNC 1`] = `
data-ouia-safe="true"
type="button"
>
Launch Remote Viewer
<span
class="pf-v6-c-button__text"
>
Launch Remote Viewer
</span>
</button>
</div>
<div
Expand Down Expand Up @@ -360,7 +368,7 @@ exports[`DesktopViewer with Spice and VNC 1`] = `
<div>
Download the MSI from
<a
href="https://virt-manager.org/download/"
href="https://virt-manager.org/download"
rel="noopener noreferrer"
target="_blank"
>
Expand Down Expand Up @@ -526,7 +534,11 @@ exports[`DesktopViewer with Spice, VNC and RDP (different hostname) 1`] = `
data-ouia-safe="true"
type="button"
>
Launch Remote Viewer
<span
class="pf-v6-c-button__text"
>
Launch Remote Viewer
</span>
</button>
<button
aria-disabled="false"
Expand All @@ -536,7 +548,11 @@ exports[`DesktopViewer with Spice, VNC and RDP (different hostname) 1`] = `
data-ouia-safe="true"
type="button"
>
Launch Remote Desktop
<span
class="pf-v6-c-button__text"
>
Launch Remote Desktop
</span>
</button>
</div>
<div
Expand Down Expand Up @@ -691,7 +707,7 @@ exports[`DesktopViewer with Spice, VNC and RDP (different hostname) 1`] = `
<div>
Download the MSI from
<a
href="https://virt-manager.org/download/"
href="https://virt-manager.org/download"
rel="noopener noreferrer"
target="_blank"
>
Expand Down Expand Up @@ -942,7 +958,11 @@ exports[`DesktopViewer with Spice, VNC and RDP 1`] = `
data-ouia-safe="true"
type="button"
>
Launch Remote Viewer
<span
class="pf-v6-c-button__text"
>
Launch Remote Viewer
</span>
</button>
<button
aria-disabled="false"
Expand All @@ -952,7 +972,11 @@ exports[`DesktopViewer with Spice, VNC and RDP 1`] = `
data-ouia-safe="true"
type="button"
>
Launch Remote Desktop
<span
class="pf-v6-c-button__text"
>
Launch Remote Desktop
</span>
</button>
</div>
<div
Expand Down Expand Up @@ -1107,7 +1131,7 @@ exports[`DesktopViewer with Spice, VNC and RDP 1`] = `
<div>
Download the MSI from
<a
href="https://virt-manager.org/download/"
href="https://virt-manager.org/download"
rel="noopener noreferrer"
target="_blank"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ exports[`SerialConsole in the DISCONNECTED state 1`] = `
data-ouia-safe="true"
type="button"
>
My text for Connect
<span
class="pf-v6-c-button__text"
>
My text for Connect
</span>
</button>
</div>
</div>
Expand All @@ -57,7 +61,11 @@ exports[`SerialConsole in the LOADING state 1`] = `
data-ouia-safe="true"
type="button"
>
Disconnect
<span
class="pf-v6-c-button__text"
>
Disconnect
</span>
</button>
<button
aria-disabled="false"
Expand All @@ -67,7 +75,11 @@ exports[`SerialConsole in the LOADING state 1`] = `
data-ouia-safe="true"
type="button"
>
Reset
<span
class="pf-v6-c-button__text"
>
Reset
</span>
</button>
</div>
<div
Expand Down Expand Up @@ -131,7 +143,11 @@ exports[`SerialConsole with CONNECTED state renders 1`] = `
data-ouia-safe="true"
type="button"
>
My text for Disconnect
<span
class="pf-v6-c-button__text"
>
My text for Disconnect
</span>
</button>
<button
aria-disabled="false"
Expand All @@ -141,7 +157,11 @@ exports[`SerialConsole with CONNECTED state renders 1`] = `
data-ouia-safe="true"
type="button"
>
Reset
<span
class="pf-v6-c-button__text"
>
Reset
</span>
</button>
</div>
<div
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ exports[`Render SerialConsoleActions 1`] = `
data-ouia-safe="true"
type="button"
>
Disconnect
<span
class="pf-v6-c-button__text"
>
Disconnect
</span>
</button>
<button
aria-disabled="false"
Expand All @@ -23,7 +27,11 @@ exports[`Render SerialConsoleActions 1`] = `
data-ouia-safe="true"
type="button"
>
Reset
<span
class="pf-v6-c-button__text"
>
Reset
</span>
</button>
</div>
</DocumentFragment>
Expand All @@ -42,7 +50,11 @@ exports[`Render SerialConsoleActions with custom texts 1`] = `
data-ouia-safe="true"
type="button"
>
My Disconnect Text
<span
class="pf-v6-c-button__text"
>
My Disconnect Text
</span>
</button>
<button
aria-disabled="false"
Expand All @@ -52,7 +64,11 @@ exports[`Render SerialConsoleActions with custom texts 1`] = `
data-ouia-safe="true"
type="button"
>
My Reconnect Text
<span
class="pf-v6-c-button__text"
>
My Reconnect Text
</span>
</button>
</div>
</DocumentFragment>
Expand Down
Loading

0 comments on commit aef5e4b

Please sign in to comment.