Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): fix dep versioning, conflicts, type #16

Merged
merged 1 commit into from
Feb 17, 2023
Merged

chore(deps): fix dep versioning, conflicts, type #16

merged 1 commit into from
Feb 17, 2023

Conversation

wise-king-sullyman
Copy link
Collaborator

Addresses dependency concerns in #14

dlabaj
dlabaj approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only a question if we should use undefined instead of null

packages/module/patternfly-docs/generated/index.js
source: "design-guidelines",
tabName: null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use undefined instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think that tabName value is just coming from the docs framework, and it's coming back as null because we don't define a specific one. It's just showing up as a change here because I bumped the docs framework version.

But yeah that seems like it might be a change we want to make in the docs framework.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that frontmatter value is coming from this PR in org https://github.com/patternfly/patternfly-org/pull/3394/files

@wise-king-sullyman wise-king-sullyman merged commit dc17a41 into main Feb 17, 2023
@wise-king-sullyman wise-king-sullyman deleted the config-hardening branch February 17, 2023 21:01
@wise-king-sullyman wise-king-sullyman mentioned this pull request Feb 17, 2023
Closed
7 tasks
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

🎉 This PR is included in version 4.87.101 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlabaj dlabaj dlabaj approved these changes

Assignees
No one assigned
Labels
released on @prerelease released on @prerelease-v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wise-king-sullyman @dlabaj