chore(docs): bumped framework and added switchers #299
+23,077
−15,793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatblindgeye
force-pushed
the
docsBumpSwitchers
branch
2 times, most recently
from
e254401 to
58b52e7
Compare
thatblindgeye
force-pushed
the
docsBumpSwitchers
branch
from
f7cc45e to
7eb9d96
Compare
wise-king-sullyman
approved these changes
Oct 22, 2025
jenny-s51
requested changes
Oct 22, 2025
There was a problem hiding this comment.
This is looking great @thatblindgeye - thanks for helping keep our versions up to date and for adding the switchers. The theming switcher looks great and works as expected - just seeing some issues when RTL switcher is enabled.
PF Topology will require additional updates to fully support RTL with our current implementation, so it may be best to disable the RTL switcher in the meantime - WDYT @thatblindgeye @jeff-phillips-18 ?
jenny-s51
reviewed
Oct 22, 2025
| port: 8008, | ||
| hasThemeSwitcher: true, | ||
| hasHighContrastSwitcher: true, | ||
| hasRTLSwitcher: true |
There was a problem hiding this comment.
Suggested change
| hasRTLSwitcher: true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #
Description
Type of change
Screen shots / Gifs for design review