Skip to content

Skip rows xlsx#42

Merged
divyanshu-tiwari merged 3 commits intomainfrom
skip-rows-xlsx
Feb 13, 2026
Merged

Skip rows xlsx#42
divyanshu-tiwari merged 3 commits intomainfrom
skip-rows-xlsx

Conversation

@divyanshu-tiwari
Copy link
Contributor

Description

This pull request adds support for skipping rows when converting Excel sheets to CSV, both globally and on a per-sheet basis. The new functionality allows users to specify a number of rows to skip at the start of each sheet, which is useful for handling header rows or other non-data content. The changes include updates to the converter implementation, documentation, and test pipelines.

Excel row skipping feature:

  • Added skip_rows and skip_rows_by_sheet options to the xlsx converter configuration, allowing users to skip a specified number of rows globally or per sheet. Per-sheet overrides take precedence over the global setting. [1] [2]
  • Updated the converter logic in xlsx.go to apply the row-skipping logic during the Excel-to-CSV conversion process. [1] [2] [3]

Documentation updates:

  • Extended the documentation in README.md to describe the new skip_rows and skip_rows_by_sheet options, including a usage example in YAML format. [1] [2]

Test pipeline updates:

  • Added and updated test pipeline YAML files to demonstrate and verify the new row-skipping behavior, including both global and per-sheet skipping scenarios. [1] [2]
  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@divyanshu-tiwari divyanshu-tiwari requested a review from a team as a code owner February 12, 2026 06:48
Copilot AI review requested due to automatic review settings February 12, 2026 06:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds configurable row-skipping support to the XLSX→CSV converter so users can drop leading header/metadata rows either globally or per-sheet (with per-sheet overrides taking precedence).

Changes:

  • Added skip_rows and skip_rows_by_sheet configuration fields to the XLSX converter and applied them during sheet iteration.
  • Documented the new XLSX converter options and provided an example configuration.
  • Updated/added pipeline examples demonstrating global and per-sheet row skipping.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
internal/pkg/pipeline/task/converter/xlsx.go Implements global/per-sheet row skipping during XLSX sheet-to-CSV conversion.
internal/pkg/pipeline/task/converter/README.md Documents skip_rows and skip_rows_by_sheet options with an example.
test/pipelines/converter/convert_xls.yaml Updates sample pipeline to demonstrate skip_rows.
test/pipelines/converter/convert_xls_with_skip_rows_by_sheets.yaml Adds sample pipeline demonstrating skip_rows_by_sheet.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
defer rows.Close()

// Write rows to buffer
i := 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a better naming convention over here?
rowIndex

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's idiomatic way in go to use short names for variable having small scope, use of single letter variable is a common practice for index.

@divyanshu-tiwari divyanshu-tiwari merged commit 2b062a1 into main Feb 13, 2026
6 checks passed
@divyanshu-tiwari divyanshu-tiwari deleted the skip-rows-xlsx branch February 13, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants