Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable row-skipping support to the XLSX→CSV converter so users can drop leading header/metadata rows either globally or per-sheet (with per-sheet overrides taking precedence).
Changes:
- Added
skip_rowsandskip_rows_by_sheetconfiguration fields to the XLSX converter and applied them during sheet iteration. - Documented the new XLSX converter options and provided an example configuration.
- Updated/added pipeline examples demonstrating global and per-sheet row skipping.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
internal/pkg/pipeline/task/converter/xlsx.go |
Implements global/per-sheet row skipping during XLSX sheet-to-CSV conversion. |
internal/pkg/pipeline/task/converter/README.md |
Documents skip_rows and skip_rows_by_sheet options with an example. |
test/pipelines/converter/convert_xls.yaml |
Updates sample pipeline to demonstrate skip_rows. |
test/pipelines/converter/convert_xls_with_skip_rows_by_sheets.yaml |
Adds sample pipeline demonstrating skip_rows_by_sheet. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| defer rows.Close() | ||
|
|
||
| // Write rows to buffer | ||
| i := 0 |
Contributor
There was a problem hiding this comment.
Can we use a better naming convention over here?
rowIndex
Contributor
Author
There was a problem hiding this comment.
It's idiomatic way in go to use short names for variable having small scope, use of single letter variable is a common practice for index.
Mayureshpawar29
approved these changes
Feb 12, 2026
prasadlohakpure
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for skipping rows when converting Excel sheets to CSV, both globally and on a per-sheet basis. The new functionality allows users to specify a number of rows to skip at the start of each sheet, which is useful for handling header rows or other non-data content. The changes include updates to the converter implementation, documentation, and test pipelines.
Excel row skipping feature:
skip_rowsandskip_rows_by_sheetoptions to thexlsxconverter configuration, allowing users to skip a specified number of rows globally or per sheet. Per-sheet overrides take precedence over the global setting. [1] [2]xlsx.goto apply the row-skipping logic during the Excel-to-CSV conversion process. [1] [2] [3]Documentation updates:
README.mdto describe the newskip_rowsandskip_rows_by_sheetoptions, including a usage example in YAML format. [1] [2]Test pipeline updates:
Checklist