Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces documentation for four new plugins (Spark, Ping, Glue, and DynamoDB) and updates the main README to include hyperlinks for each plugin's documentation.
- Adds README documentation for the Spark plugin, detailing its usage for running SparkSQL queries on EMR on EKS.
- Adds README documentation for the Ping, Glue, and DynamoDB plugins including command definitions and sample job submissions.
- Updates the main README to link to the new plugin docs and adjust the execution mode descriptions.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/spark/README.md | New documentation for the Spark plugin with usage examples |
| plugins/ping/README.md | New documentation for the Ping plugin including command definitions |
| plugins/glue/README.md | New documentation for the Glue plugin with sample job submission |
| plugins/dynamo/README.md | New documentation for the DynamoDB plugin with detailed usage examples |
| README.md | Updated table entries with hyperlinks to the plugin documentation |
Comments suppressed due to low confidence (1)
README.md:93
- The Ping Plugin's documentation indicates a synchronous execution mode while the table entry lists it as 'Sync or Async'. Please ensure the execution mode is consistently described across the documentation.
| `ping` | [Basic plugin used for testing](https://github.com/patterninc/heimdall/blob/main/plugins/ping/README.md) | Sync or Async |
wlggraham
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.