Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to run Spark applications using JAR files in addition to the existing SQL query functionality. The changes extend the Spark plugin to support custom entry points and arguments for executing Spark applications.
Key changes:
- Extended job context to support JAR-based Spark applications with entry points and custom arguments
- Updated parameter generation to include Spark class configuration for JAR execution
- Enhanced documentation with usage examples for both SQL and JAR-based workflows
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/spark/README.md | Added documentation and examples for JAR-based Spark applications with entry points and arguments |
| internal/pkg/object/command/spark/spark.go | Extended job context struct and logic to support JAR execution with entry points and custom arguments |
hladush
force-pushed
the
stan_spark_args
branch
3 times, most recently
from
17b41cd to
c43e0b1
Compare
babourine
reviewed
Jul 21, 2025
babourine
reviewed
Jul 22, 2025
babourine
reviewed
Jul 22, 2025
babourine
reviewed
Jul 22, 2025
babourine
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an ability to run spark applications
Tested on EMR
