Adding spark plugin to support spark jobs over EMR on EKS#3
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
A new spark plugin has been added to support the submission and execution of Spark jobs over EMR on EKS. Key changes include:
- Introducing a spark plugin handler in plugins/spark/spark.go that wraps the internal spark command logic.
- Implementing the spark job submission flow with support for AWS EMR containers and assume role credentials in internal/pkg/object/command/spark/spark.go.
- Updating go.mod to include necessary AWS SDK dependencies for EMR containers and S3 manager.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/spark/spark.go | Added a new plugin handler wrapping the spark command implementation. |
| internal/pkg/object/command/spark/spark.go | Implements the spark job execution flow including context unmarshalling, AWS client setup, and job polling. |
| go.mod | Updated module dependencies to include the AWS EMR containers service and S3 manager. |
Comments suppressed due to low confidence (1)
plugins/spark/spark.go:1
- Consider renaming the package from 'main' to 'spark' to maintain consistency with the plugin's directory structure and its intended usage.
package main
| return nil, fmt.Errorf("failed to list virtual clusters: %w", err) | ||
| } | ||
|
|
||
| for _, vc := range outputListClusters.VirtualClusters { |
There was a problem hiding this comment.
Consider adding a nil check for vc.Name before dereferencing it to avoid potential runtime panics in cases where the cluster name may be missing.
Suggested change
| for _, vc := range outputListClusters.VirtualClusters { | |
| for _, vc := range outputListClusters.VirtualClusters { | |
| if vc.Name == nil { | |
| continue | |
| } |
wlggraham
approved these changes
May 9, 2025
wlggraham
pushed a commit
that referenced
this pull request
May 9, 2025
Add PR Template copied from Airflow Repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.