Changes I would make to the tailwind PR#33
Changes I would make to the tailwind PR#33gauravwarale merged 1 commit intopatterninc:CU-86dxezft7_Upgrade-tailwind-4-for-heimdallfrom ryankshaw:ry/tailwind
Conversation
These are the things I would do differently in your PR. this PR is made as a PR to your PR so if you like it you can merge it and it will be merged into your branch
| { | ||
| "jsxSingleQuote": true, | ||
| "plugins": ["prettier-plugin-sort-json"], | ||
| "plugins": ["prettier-plugin-sort-json", "prettier-plugin-tailwindcss"], |
There was a problem hiding this comment.
you don't need this but it makes life a lot better when dealing with tailwind classes
| /* you might want to consider adding this preflight line here. it enables tailwind's preflight. we can't do it by default in our other apps because they are relying on their own css reset but if you can it will make your app look more like "standard" tailwind */ | ||
| /* @import "tailwindcss/preflight.css" layer(base); */ |
There was a problem hiding this comment.
if you can use tailwind's preflight, I would. we can't in our other apps but you should if you can
| import ClientLayout from '@/common/ClientLayout/ClientLayout' | ||
| import { NuqsAdapter } from 'nuqs/adapters/next/app' | ||
| import './globals.css' | ||
| import '../../node_modules/@patterninc/react-ui/dist/pattern-themed-tailwind.css' |
There was a problem hiding this comment.
you don't want to pull in pattern-themed-tailwind.css as it's own css file. you want to pull it in where you were pulling in "tailwind" in your css file
| @@ -1,19 +0,0 @@ | |||
| import type { Config } from 'tailwindcss' | |||
There was a problem hiding this comment.
I don't think you need this configuration file anymore. since tailiwind v4 uses css based configuration
| "./src/*" | ||
| ] | ||
| }, | ||
| "target": "ES2017" |
There was a problem hiding this comment.
This isn't necessarily part of upgrading to tailwind, but I noticed this while playing with your pr. all the browsers we support support at lest es2022 so you can bump this so you can get access to more stuff like Array.at or whatever
| }, | ||
| "overrides": { | ||
| "@types/react": "19.1.6", | ||
| "@types/react-dom": "19.1.6" |
There was a problem hiding this comment.
you shouldn't need these anymore. not related to tailwind but something you could clean up
gauravwarale
merged commit 5900649
into
patterninc:CU-86dxezft7_Upgrade-tailwind-4-for-heimdall
2 participants
These are the things I would do differently in your PR. this PR is made as a PR to your PR so if you like it you can merge it and it will be merged into your branch