Including whole objects to the the context for shell commands to have access to#36
Merged
Including whole objects to the the context for shell commands to have access to#36
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the context available to shell commands by providing access to complete objects instead of just their context fields. The change allows shell scripts to access full object properties through JSON parsing with jq.
- Changed
runtimeContextstruct to include complete objects (*job.Job,*cluster.Cluster) instead of just their context fields - Added
Runtimefield to provide access to the runtime object - Updated Golang base image version from 1.24.5 to 1.24.6
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/pkg/object/command/shell/shell.go | Modified runtimeContext to include full objects and added Runtime field for enhanced shell command access |
| Dockerfile | Updated Golang base image to version 1.24.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.