Skip to content

Update old job biggest id #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hladush merged 1 commit into from
Feb 26, 2026
Merged

Update old job biggest id #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/pkg/janitor/queries/old_job_biggest_id.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
SELECT system_job_id
FROM jobs
WHERE updated_at < $1
ORDER BY updated_at desc
ORDER BY system_job_id desc
LIMIT 1
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with other janitor SQL queries (e.g. stale_and_canceling_jobs_select.sql, old_jobs_delete.sql), this statement should end with a trailing semicolon. That also avoids accidental issues if the embedded SQL ever gets concatenated with additional statements.

Suggested change
LIMIT 1
LIMIT 1;

Copilot uses AI. Check for mistakes.