Skip to content

Fix CI config by ensuring deployment unset before installing dependencies #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MSD118 wants to merge 2 commits into from
Closed

Fix CI config by ensuring deployment unset before installing dependencies #69

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af9a415
Fix CI configuration by commenting out bundler-cache and ensuring dep…
MSD118 Feb 16, 2026
f34b3c7
Fix CI and Brakeman workflows by ensuring BUNDLE_DEPLOYMENT is set to…
MSD118 Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/brakeman.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@ jobs:
# Not needed with a .ruby-version file
ruby-version: 2.7.2
# runs 'bundle install' and caches installed gems automatically
bundler-cache: true
# bundler-cache: true

Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is trailing whitespace on these lines (after the commented bundler-cache line and on the blank line). Consider removing it to avoid lint noise and keep diffs clean.

Suggested change
# bundler-cache: true
# bundler-cache: true

Copilot uses AI. Check for mistakes.
- name: unset deployment
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step names in this workflow are capitalized (e.g., "Set up Ruby…", "Install dependencies"), but this new step is not. Rename it to match the existing naming style for consistency and readability.

Suggested change
- name: unset deployment
- name: Unset deployment

Copilot uses AI. Check for mistakes.
run: bundle config unset deployment

- name: Install dependencies
run: bundle install
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemfile.lock pins Bundler via BUNDLED WITH 2.2.29, but this workflow no longer uses bundler-cache and doesn’t explicitly install/pin a Bundler version. Depending on the runner’s default Bundler, bundle install can fail with a Bundler version mismatch. Consider explicitly installing/pinning the Bundler version (or configuring ruby/setup-ruby to use the lockfile’s Bundler) before running bundle install.

Copilot uses AI. Check for mistakes.

- name: Brakeman install
run: gem install brakeman -v 5.4.1
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,13 @@ jobs:
# Not needed with a .ruby-version file
ruby-version: 2.7.2
# runs 'bundle install' and caches installed gems automatically
bundler-cache: true
# bundler-cache: true

- name: unset deployment
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step names in this workflow are capitalized (e.g., "Set up Ruby…", "Install dependencies", "Run tests"), but this new step is not. Rename it to match the existing naming style for consistency and readability.

Suggested change
- name: unset deployment
- name: Unset deployment

Copilot uses AI. Check for mistakes.
run: bundle config unset deployment

- name: Install dependencies
run: bundle install
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gemfile.lock pins Bundler via BUNDLED WITH 2.2.29, but this workflow no longer uses bundler-cache and doesn’t explicitly install/pin a Bundler version. Depending on the runner’s default Bundler, bundle install can fail with a Bundler version mismatch. Consider explicitly installing/pinning the Bundler version (or configuring ruby/setup-ruby to use the lockfile’s Bundler) before running bundle install.

Copilot uses AI. Check for mistakes.

- name: Run tests
run: bundle exec rspec spec