Improve complex log

paulmasson · Jan 23, 2025 · 81a44bb · 81a44bb
1 parent 88b535b
commit 81a44bb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/build/math.js b/build/math.js
@@ -3354,11 +3354,11 @@ function logisticSigmoid( x ) { return inv( add( 1, exp(neg(x)) ) ); }
 
 function log( x, base ) {
 
-  if ( isComplex(x) ) {
+  if ( isComplex(x) || isComplex(base) ) {
 
-    if ( isComplex(base) ) return div( log(x), log(base) );
+    if ( base === undefined ) return { re: Math.log( abs(x) ), im: arg(x) };
 
-    return { re: log( abs(x), base ), im: log( Math.E, base ) * arg(x) };
+    return div( log(x), log(base) );
 
   }
 

diff --git a/src/functions/logarithm.js b/src/functions/logarithm.js
@@ -49,11 +49,11 @@ function logisticSigmoid( x ) { return inv( add( 1, exp(neg(x)) ) ); }
 
 function log( x, base ) {
 
-  if ( isComplex(x) ) {
+  if ( isComplex(x) || isComplex(base) ) {
 
-    if ( isComplex(base) ) return div( log(x), log(base) );
+    if ( base === undefined ) return { re: Math.log( abs(x) ), im: arg(x) };
 
-    return { re: log( abs(x), base ), im: log( Math.E, base ) * arg(x) };
+    return div( log(x), log(base) );
 
   }