Skip to content

Commit

Permalink
Prepare 6.4.1
Browse files Browse the repository at this point in the history
  • Loading branch information
paulrosen committed Jun 18, 2024
1 parent 296221a commit cd21516
Showing 7 changed files with 22 additions and 11 deletions.
8 changes: 8 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# Version 6.4.1

## Bugs

* fix regression when playing a specified sequence instead of using visualObj

* don't inject a bass note when chords change mid-measure if the pattern doesn't start on a bass note.

# Version 6.4.0

## Features
4 changes: 2 additions & 2 deletions dist/abcjs-basic-min.js

Large diffs are not rendered by default.

11 changes: 7 additions & 4 deletions dist/abcjs-basic.js
Original file line number Diff line number Diff line change
@@ -13577,8 +13577,8 @@ ChordTrack.prototype.resolveChords = function (startTime, endTime) {
if (p > 0 && currentChordsExpanded[p - 1] && currentChordsExpanded[p] && currentChordsExpanded[p - 1].boom !== currentChordsExpanded[p].boom) firstBoom = true;
var type = thisPattern[p];
var isBoom = type.indexOf('boom') >= 0;
// If we changed chords at a time when we're not expecting a bass note, then add an extra bass note in.
var newBass = !isBoom && p !== 0 && (!currentChordsExpanded[p - 1] || currentChordsExpanded[p - 1].boom !== currentChordsExpanded[p].boom);
// If we changed chords at a time when we're not expecting a bass note, then add an extra bass note in if the first thing in the pattern is a bass note.
var newBass = !isBoom && p !== 0 && thisPattern[0].indexOf('boom') >= 0 && (!currentChordsExpanded[p - 1] || currentChordsExpanded[p - 1].boom !== currentChordsExpanded[p].boom);
var pitches = resolvePitch(currentChordsExpanded[p], type, firstBoom, newBass);
if (isBoom) firstBoom = false;
for (var oo = 0; oo < pitches.length; oo++) {
@@ -14261,7 +14261,10 @@ function CreateSynth() {
self.sequenceCallback = params.sequenceCallback;
self.callbackContext = params.callbackContext;
self.onEnded = params.onEnded;
self.meterFraction = options.visualObj.getMeterFraction();
self.meterFraction = options.visualObj ? options.visualObj.getMeterFraction() : {
den: 1
}; // If we are given a sequence instead of a regular visual obj, then don't do the swing

var allNotes = {};
var cached = [];
var errorNotes = [];
@@ -26376,7 +26379,7 @@ module.exports = Svg;
\********************/
/***/ (function(module) {

var version = '6.4.0';
var version = '6.4.1';
module.exports = version;

/***/ })
2 changes: 1 addition & 1 deletion dist/abcjs-basic.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/abcjs-plugin-min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "abcjs",
"version": "6.4.0",
"version": "6.4.1",
"description": "Renderer for abc music notation",
"main": "index.js",
"types": "types/index.d.ts",
2 changes: 1 addition & 1 deletion version.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
var version = '6.4.0';
var version = '6.4.1';

module.exports = version;

0 comments on commit cd21516

Please sign in to comment.