Work towards more constant methods #749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I didn't realize in #360,
rust_decimal::Error
conflicts with CTFE (Constant Time Function Evaluator) because of the variants that useString
.For example, the following should be possible but isn't at the current time.
The idea to workaround this limitation is to convert all string errors into error variants starting with the
from_scientific_exact
function. Technically a breaking change but such a thing already occurred before without a version bump.Feel free to close this PR if desired.