Add o1heapMinArenaSize, o1heapGetMaxAllocationSize() #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds tests for validating the minimum arena size and maximum allocation size of the heap, as well as exposing a new API for retrieving the maximum allocation size from a heap instance.
- Adds new test cases in tests/test_general.cpp to verify arena sizing.
- Adds a getter method in tests/internal.hpp for the maximum allocation size.
- Updates o1heap.h and o1heap.c to define o1heapMinArenaSize and implement o1heapGetMaxAllocationSize.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_general.cpp | Adds new test cases for verifying arena size boundaries and allocations. |
| tests/internal.hpp | Introduces an inline getter for max allocation size using the public API. |
| o1heap/o1heap.h | Documents and declares the new constant and API for max allocation size. |
| o1heap/o1heap.c | Implements the new constant and API, and refines inline comments. |
This was
linked to
issues
May 10, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.