Enable overriding environ values #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziima
requested changes
Apr 22, 2020
ziima
reviewed
Apr 22, 2020
ziima
approved these changes
Apr 22, 2020
rastytheamateur
force-pushed
the
override-environ-values
branch
from
c9ddb5e
to
8525d29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django's
override_settingsdoes not override values taken fromos.environ.After a discussion we agreed with @ziima that the best way to fix this is to temporarily rename affected keys in
os.environ. Thesetting_changedsignal is received whensettings_overrideis called andsettings_overrideshould be used just and only in tests, so this solution should have no impact on usual use.