fix(ui): properly reflects hook changes in ui #10268
Open
+108
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsfletch
changed the title
jacobsfletch
reviewed
Jan 2, 2025
| }, [initialState]) | ||
|
|
||
| useEffect(() => { | ||
| setInitialState(initialState) |
There was a problem hiding this comment.
You have the identical useEffect functions written twice here.
jacobsfletch
reviewed
Jan 2, 2025
| @@ -260,6 +266,14 @@ const DocumentInfo: React.FC< | |||
| [], | |||
| ) | |||
|
|
|||
| useEffect(() => { | |||
| setInitialState(initialState) | |||
There was a problem hiding this comment.
This useEffect appears unnecessary. Do you mean to put initialStateFromProps as the dependency?
There was a problem hiding this comment.
In that case, a useMemo might make more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9882 and #9691
In 2.0, we would accept data coming back from an update operation and then reflect those changes in UI.
However, in 3.0, we did not do that anymore - meaning you could change a document with hooks in
beforeChangeorafterChange, but then not see the changes made on the server.Now, we store
initialStateandinitialDatainDocumentInfoProviderand update them when we save a document.Note that this does not apply to autosave.