fix: ensure loggingLevels is respected
#10308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: ensure `loggingLevels` is respected, import
r1tsuu
force-pushed
the
fix/respsect-logging-level
branch
from
1985601 to
9e71279
Compare
DanRibbens
approved these changes
Jan 2, 2025
| if (level) { | ||
| payload.logger[level]( | ||
| level === 'info' | ||
| ? { msg: typeof err === 'object' && 'message' in err ? err.message : 'Error' } |
There was a problem hiding this comment.
I always try to avoid double ternaries as a general rule.
| import type { Payload } from '../types/index.js' | ||
|
|
||
| export const logError = ({ err, payload }: { err: unknown; payload: Payload }): void => { | ||
| let level: pino.Level = 'error' |
There was a problem hiding this comment.
The type should be pino.Level | false, if we were in strict mode L15 would error since it doesn't match the loggingLevels type from the config.
r1tsuu
added a commit
that referenced
this pull request
Jan 2, 2025
Issue #10272 Adds `logError` utility that can be used across the codebase for logging errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10272
Adds
logErrorutility that can be used across the codebase for logging errors