fix(email-nodemailer): Fix skipVerify behaviour being reversed #6790
+61
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denolfe
requested changes
Jun 17, 2024
There was a problem hiding this comment.
@JasperBeaurain Thanks for the PR! Just one additional scenario that needs to be handled.
| @@ -66,7 +66,7 @@ async function buildEmail(emailConfig?: NodemailerAdapterArgs): Promise<{ | |||
| transport = await createMockAccount(emailConfig) | |||
| } | |||
|
|
|||
| if (emailConfig.skipVerify !== false) { | |||
| if (emailConfig.skipVerify === false) { | |||
There was a problem hiding this comment.
This also needs to handle when skipVerify is undefined. It should verify when undefined.
So this could either be if (!emailConfig.skipVerify) or if (emailConfig.skipVerify !== true).
…ify is undefined (the transport should be verified)
|
@denolfe Whoops, I missed that indeed. Made changes as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6789
The skipVerify field in NodemailerAdapterArgs worked in reverse of what it was supposed to do:
This PR makes the property work in the intended way:
With skipVerify = true -> DO NOT verify transport
With skipVerify = false -> DO verify transport
I have read and understand the CONTRIBUTING.md document in this repository.
Type of change
Checklist: