fix(plugin-nested-docs): publishing parent doc should not publish child doc #9958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessChowdhury
force-pushed
the
fix/plugin-nested-docs-overwrite
branch
from
50b7e49 to
6404dd4
Compare
DanRibbens
approved these changes
Dec 13, 2024
DanRibbens
reviewed
Dec 13, 2024
| @@ -136,5 +136,18 @@ describe('Nested Docs Plugin', () => { | |||
| // TODO: add back when error states are fixed | |||
| // await expect(parentSlugInChild).toHaveValue('/parent-slug-draft') | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
I would have probably used an int.spec. They tend to run faster and are easier to debug.
|
🚀 This is included in version v3.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Issue
Draft children documents get overwritten when the parent document is published.
Fix
Correctly retrieve all documents, including drafts, during the resave process. Add test to ensure parent documents can be published without impacting the state of any children docs.