refactor: use new SDK method for global identifier #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonacox-paypal
changed the title
jeremy-herman
approved these changes
Oct 3, 2025
danzhaaspaypal
approved these changes
Oct 3, 2025
Seavenly
reviewed
Oct 6, 2025
| requestDuration: getRequestDuration() | ||
| requestDuration: getRequestDuration(), | ||
| // Global Session ID allows messages to be correlated to button events | ||
| globalSessionID: getGlobalSessionID() |
There was a problem hiding this comment.
There's another spot below where onReady can be called for the rerender use case where we should include this to stay consistent and prevent accidentally removing the value if it were to be omitted.
There was a problem hiding this comment.
Thanks Nate, I've addressed the re-render logic
Seavenly
approved these changes
Oct 6, 2025
Seavenly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Testing instructions