feat: Remove Issue findAll (#9)

- 서비스, 컨트롤러, 레포지토리에서 findAll 삭제
pbg0205 · Jun 23, 2021 · aa93f92 · aa93f92
1 parent c97d74b
commit aa93f92
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 17 deletions.
diff --git a/BE/src/main/java/com/codesquad/issuetracker/issue/controller/IssueController.java b/BE/src/main/java/com/codesquad/issuetracker/issue/controller/IssueController.java
@@ -23,11 +23,6 @@ public IssueWrapper readIssue(@PathVariable Long id) {
         return issueService.readIssueById(id);
     }
 
-    @GetMapping
-    public IssuesWrapper readAllIssues() {
-        return issueService.readAllIssues();
-    }
-
     @PostMapping
     public IssueWrapper createIssue(@RequestBody IssueCreateRequest issueCreateRequest, @RequestAttribute User authUser) {
         return issueService.createIssue(issueCreateRequest, authUser);

diff --git a/BE/src/main/java/com/codesquad/issuetracker/issue/infra/IssueRepository.java b/BE/src/main/java/com/codesquad/issuetracker/issue/infra/IssueRepository.java
@@ -6,6 +6,4 @@
 import java.util.List;
 
 public interface IssueRepository extends CrudRepository<Issue, Long> {
-    @Override
-    List<Issue> findAll();
 }
diff --git a/BE/src/main/java/com/codesquad/issuetracker/issue/service/IssueService.java b/BE/src/main/java/com/codesquad/issuetracker/issue/service/IssueService.java
@@ -2,7 +2,10 @@
 
 import com.codesquad.issuetracker.comment.domain.Comment;
 import com.codesquad.issuetracker.comment.infra.CommentRepository;
-import com.codesquad.issuetracker.exception.*;
+import com.codesquad.issuetracker.exception.IssueNotFoundException;
+import com.codesquad.issuetracker.exception.LabelNotFoundException;
+import com.codesquad.issuetracker.exception.MilestoneNotFoundException;
+import com.codesquad.issuetracker.exception.UserNotFoundException;
 import com.codesquad.issuetracker.issue.domain.Issue;
 import com.codesquad.issuetracker.issue.dto.*;
 import com.codesquad.issuetracker.issue.infra.IssueRepository;
@@ -18,7 +21,6 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.UUID;
-import java.util.stream.Collectors;
 
 @Service
 public class IssueService {
@@ -74,7 +76,7 @@ public IssueWrapper readIssueById(Long id) {
     }
 
     @Transactional
-    public IssueWrapper updateIssue (IssueRequest issueRequest, Long id) {
+    public IssueWrapper updateIssue(IssueRequest issueRequest, Long id) {
         Issue issue = issueRepository.findById(id).orElseThrow(IssueNotFoundException::new);
         List<Comment> comments = commentRepository.findAllByIssueId(id);
         issue.updateIssue(issueRequest);
@@ -124,11 +126,4 @@ public void removeMilestone(Long id) {
         issue.removeMilestone();
     }
 
-    public IssuesWrapper readAllIssues() {
-        return IssuesWrapper.wrap(
-                issueRepository.findAll().stream()
-                .map(IssueSummaryResponse::fromEntity)
-                .collect(Collectors.toList())
-        );
-    }
 }