feat: coordinator를 채택한 구체타입을 감춤 (#61)

pbg0205 · Jul 20, 2021 · e4382d3 · e4382d3
1 parent 2934a8e
commit e4382d3
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 13 deletions.
diff --git a/iOS/issue-tracker.xcodeproj/project.pbxproj b/iOS/issue-tracker.xcodeproj/project.pbxproj
@@ -167,7 +167,7 @@
 				10D4258326709D3300AE119C /* Extension */,
 				10BCA8A3266F38D700DBBA61 /* Login */,
 				10ED3B7E2671C1F600FCBF2E /* Photo */,
-				10ED3B7D2671AFA000FCBF2E /* NewIssue */,
+				10ED3B7D2671AFA000FCBF2E /* IssueEdit */,
 				10D4258026709CB000AE119C /* IssueList */,
 			);
 			path = "issue-tracker";
@@ -193,13 +193,13 @@
 			path = Extension;
 			sourceTree = "<group>";
 		};
-		10ED3B7D2671AFA000FCBF2E /* NewIssue */ = {
+		10ED3B7D2671AFA000FCBF2E /* IssueEdit */ = {
 			isa = PBXGroup;
 			children = (
 				1029609A26733FB800669988 /* IssueEdit.storyboard */,
 				10BDE6B42670C324007B38AF /* IssueEditViewController.swift */,
 			);
-			path = NewIssue;
+			path = IssueEdit;
 			sourceTree = "<group>";
 		};
 		10ED3B7E2671C1F600FCBF2E /* Photo */ = {

diff --git a/iOS/issue-tracker/Common/Coordinator.swift b/iOS/issue-tracker/Common/Coordinator.swift
@@ -8,5 +8,13 @@
 import UIKit
 
 protocol Coordinator: AnyObject {
+
     var navigationController: UINavigationController { get set }
+    func present(view: PresentableView)
+}
+
+enum PresentableView {
+    case IssueList
+    case IssueEdit
+    case ImagePicker
 }
diff --git a/...er/NewIssue/IssueEditViewController.swift → ...r/IssueEdit/IssueEditViewController.swift b/...er/NewIssue/IssueEditViewController.swift → ...r/IssueEdit/IssueEditViewController.swift
@@ -40,10 +40,7 @@ class IssueEditViewController: UIViewController, ReuseIdentity {
 
     @objc
     func insertPhoto() {
-        guard let issueCoordinator = coordinator as? IssueCoordinator else {
-            return
-        }
-        issueCoordinator.pushImagePickerView()
+        coordinator?.present(view: .ImagePicker)
     }
 
 }

diff --git a/iOS/issue-tracker/IssueList/IssueCoordinator.swift b/iOS/issue-tracker/IssueList/IssueCoordinator.swift
@@ -16,6 +16,19 @@ class IssueCoordinator: NSObject, Coordinator {
         createIssueListVC()
     }
 
+    func present(view: PresentableView) {
+        switch view {
+        case .IssueList:
+            createIssueListVC()
+        case .IssueEdit:
+            pushEditView()
+        case .ImagePicker:
+            pushImagePickerView()
+        default:
+            return
+        }
+    }
+
     private func createIssueListVC() {
         guard let issueListVC = IssueListViewController.instantiate(name: StoryBoardName.IssueList.description) else {
             return
@@ -29,15 +42,15 @@ class IssueCoordinator: NSObject, Coordinator {
         issueListVC.coordinator = self
     }
 
-    func pushEditView() {
+    private func pushEditView() {
         guard let issueEditVC = IssueEditViewController.instantiate(name: StoryBoardName.IssueEdit.description) else {
             return
         }
         issueEditVC.coordinator = self
         navigationController.pushViewController(issueEditVC, animated: true)
     }
 
-    func pushImagePickerView() {
+    private func pushImagePickerView() {
         let imagePickerDelegate = ImagePickerDelegate()
         let imagePicker = ImagePicker.init(presentationController: self.navigationController, delegate: imagePickerDelegate)
         imagePicker.coordinator = self

diff --git a/iOS/issue-tracker/IssueList/IssueListViewController.swift b/iOS/issue-tracker/IssueList/IssueListViewController.swift
@@ -12,10 +12,7 @@ class IssueListViewController: UIViewController, ReuseIdentity {
     weak var coordinator: Coordinator?
 
     @IBAction func pushToEditView(_ sender: Any) {
-        guard let issueCoordinator = coordinator as? IssueCoordinator else {
-            return
-        }
-        issueCoordinator.pushEditView()
+        coordinator?.present(view: .IssueEdit)
     }
 
     override func viewDidLoad() {