Skip to content

fixed some issues - #119

Open
shubhsahu066 wants to merge 5 commits into
pclubiitk:devfrom
shubhsahu066:dev
Open

fixed some issues#119
shubhsahu066 wants to merge 5 commits into
pclubiitk:devfrom
shubhsahu066:dev

Conversation

@shubhsahu066

@shubhsahu066 shubhsahu066 commented Jul 25, 2026

Copy link
Copy Markdown

Summary by Sourcery

Validate event times and enforce title length limits across notices and calendar events while improving mobile drawer/modal behavior.

New Features:

  • Add client- and server-side validation to prevent event end times from preceding start times.
  • Limit event and notice titles to 50 characters with corresponding form constraints and schema updates.
  • Introduce a useHistoryBack hook to intercept browser back navigation for closing drawers and modals on mobile.

Bug Fixes:

  • Avoid creating events from notices with invalid or pre-1970 timestamps and fall back to reasonable defaults for invalid end times.
  • Prevent isoToDatetimeLocal from returning invalid values for malformed or pre-1970 dates.

Enhancements:

  • Refine notice form payload mapping to align field names with backend expectations.
  • Trigger calendar form validation when date and time fields change to keep recurrence and end-date rules in sync.

@sourcery-ai

sourcery-ai Bot commented Jul 25, 2026

Copy link
Copy Markdown

🧙 Sourcery is reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant