Fix linker error: undefined symbol core::panicking::panic#52
Merged
boozook merged 1 commit intopd-rs:mainfrom Sep 15, 2023
Merged
Fix linker error: undefined symbol core::panicking::panic#52boozook merged 1 commit intopd-rs:mainfrom
core::panicking::panic#52boozook merged 1 commit intopd-rs:mainfrom
Conversation
Builds with `-Z build-std-features=panic_immediate_abort` to ensure the `core::panicking` plumbing is stripped. See: rust-lang/rust#55011 Adds `-Cpanic=abort` to RUSTFLAGS so that build profiles do not need to specify `panic = "abort"` in Cargo.toml. This can potentially allow simulator builds to customize panics. (Maybe printing to the console and stopping the event loop, for instance. But this work is TBD.) Fixes pd-rs/crankstart#66
boozook
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds with
-Z build-std-features=panic_immediate_abortto ensure thecore::panickingplumbing is stripped.See: rust-lang/rust#55011
Adds
-Cpanic=abortto RUSTFLAGS so that build profiles do not need to specifypanic = "abort"in Cargo.toml. This can potentially allow simulator builds to customize panics. (Maybe printing to the console and stopping the event loop, for instance. But this work is TBD.)Fixes pd-rs/crankstart#66