This is the official name in PDF 2.0

pdf-raku · Oct 25, 2023 · 125bf6b · 125bf6b
1 parent 0d9b55f
commit 125bf6b
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/Changes b/Changes
@@ -1,4 +1,6 @@
 {{$NEXT}}
+  - Use 'DocumentFragment' to name document fragments. It's the
+    official name in PDF 2.0
 
 0.1.12  2023-10-21T09:20:59+13:00
   - Add support for Lang attribute in XML and element construction 

diff --git a/lib/PDF/Tags/Elem.rakumod b/lib/PDF/Tags/Elem.rakumod
@@ -250,7 +250,7 @@ class PDF::Tags::Elem
         die "element contains multiple xobjects" if @xobjects > 1;
         my PDF::XObject:D $Stm = @xobjects[0];
         my PDF::Tags::Elem $node = $frag.copy-tree(:$Stm, :$parent);
-        if $node.name eq '#frag' {
+        if $node.name eq 'DocumentFragment' {
             $parent.add-kid(:node($_)) for $node.kids;
         }
         else {

diff --git a/lib/PDF/Tags/Node.rakumod b/lib/PDF/Tags/Node.rakumod
@@ -13,7 +13,7 @@ class PDF::Tags::Node {
     use Method::Also;
 
     my subset TagName of Str is export(:TagName)
-        where Str:U | /^<ident>$/ | '#frag';
+        where Str:U | /^<ident>$/;
 
     has PDF::Tags::Node::Root $.root is required handles<role-map>;
     has PDF::Page $.Pg; # current page scope

diff --git a/lib/PDF/Tags/Node/Parent.rakumod b/lib/PDF/Tags/Node/Parent.rakumod
@@ -54,13 +54,13 @@ class PDF::Tags::Node::Parent
     method !adopt-node($node) {
         # checks
         die "unable to add fragment"
-            if $node.name eq '#frag';
+            if $node.name eq 'DocumentFragment';
         die "unable to add a node to itself"
             if $node === self || $node.cos === self.cos;
 
         with $node.parent {
             die "node already parented"
-                unless $_ === self || .name eq '#frag';
+                unless $_ === self || .name eq 'DocumentFragment';
         }
 
         # re-parent cos node
@@ -109,7 +109,7 @@ class PDF::Tags::Node::Parent
         my $parent = self.WHAT;
         self.build-kid($cos, :$parent, |%o);
     }
-    multi method fragment(Str:D $name = '#frag', *%o) {
+    multi method fragment(Str:D $name = 'DocumentFragment', *%o) {
         self.fragment(:$name, |%o);
     }
     multi method FALLBACK(Str:D $name where $_ ∈ TagSet, |c) {

diff --git a/t/write-tags.t b/t/write-tags.t
@@ -86,7 +86,7 @@ $page.graphics: -> $gfx {
         my $p = $form-frag.Paragraph: $_, {
             .say: "Some sample tagged text", :font($body-font), :$font-size;
         };
-        is $p.node-path, '#frag/P[1]';
+        is $p.node-path, 'DocumentFragment/P[1]';
     }
 
     $doc.do($gfx, $form-frag, :position[150, 70]);