Make BMAD dependency preflight read-only - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- replace the stateful BMAD dependency invocation with a local read-only structural preflight\n- keep release/reference drift and state-cache write failures nonblocking\n- stop suggesting automatic BMAD check/sync remediation during task startup\n- verify installer behavior through the read-only X3 gate\n\n## Why\n\nThe previous compact gate invoked BMAD's sync helper even for a health check. In sandboxed Codex sessions that helper could write under ~/.codex, fail with PermissionError, and make X3/X4 appear unhealthy. That created unnecessary sync prompts and blocked normal work.\n\nThe new gate checks the installed local capability directly. Missing or structurally unusable BMAD files still fail closed. Update freshness remains advisory.\n\n## Verification\n\n- 107 deterministic tests passed using the same commands as main CI\n- X1, X2, X3, and X4 smoke checks all allow execution\n- X3 and X4 return bmad_status=ok with no remediation\n- the regression suite proves an unwritable BMADX state cache does not block X3 or suggest synchronization\n- git diff --check and Python byte-compilation passed\n\n## Scope\n\nThis PR intentionally excludes the unfinished value-study benchmark and its performance claims.