Skip to content

Commit

Permalink
Use corepack to manage the pnpm version (bluesky-social#2680)
Browse files Browse the repository at this point in the history
* use corepack, specify package manager, add nvmrc

* rm version in github action

---------

Co-authored-by: Samuel Newman <[email protected]>
  • Loading branch information
mozzius and mozzius authored Aug 26, 2024
1 parent bbca17b commit 70e2bff
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 5 deletions.
1 change: 0 additions & 1 deletion .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v4
with:
version: 8
- uses: actions/setup-node@v3
with:
node-version: 18
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/repo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jobs:
- uses: pnpm/action-setup@v4
name: Install pnpm
with:
version: 8
run_install: false
- uses: actions/setup-node@v4
with:
Expand All @@ -45,7 +44,6 @@ jobs:
- uses: pnpm/action-setup@v4
name: Install pnpm
with:
version: 8
run_install: false
- uses: actions/setup-node@v4
with:
Expand All @@ -66,7 +64,6 @@ jobs:
- uses: pnpm/action-setup@v4
name: Install pnpm
with:
version: 8
run_install: false
- uses: actions/setup-node@v4
with:
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ deps: ## Installs dependent libs using 'pnpm install'
nvm-setup: ## Use NVM to install and activate node+pnpm
nvm install 18
nvm use 18
npm install --global pnpm
corepack enable
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"engines": {
"node": ">=18"
},
"packageManager": "[email protected]",
"scripts": {
"lint:fix": "pnpm lint --fix",
"lint": "eslint . --ext .ts,.js",
Expand Down

0 comments on commit 70e2bff

Please sign in to comment.